Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1476810ybt;
        Thu, 9 Jul 2020 08:00:03 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwvXl8u9BWXpriYLSN8H2pkJ3gKH0Uwnn4oZFNrL9mnVg6YkHDdlBIIkLbf5r4XzoWL8Odr
X-Received: by 2002:a17:906:404e:: with SMTP id y14mr55697966ejj.260.1594306803503;
        Thu, 09 Jul 2020 08:00:03 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1594306803; cv=none;
        d=google.com; s=arc-20160816;
        b=f+hPX/rcnjl5fmlwOsOQpLU3UhSWG3D+1zlMOLt8aRDoP2BEYa39+auhZYft9FsrmF
         nwVeXQhRuwVJa+EvlePIho+Bsg0ppsSvHAO5No2CDn9DT2miARjthR/BhepG5h0cb47H
         K3I6ew0ALfOXix2bA/WdQKVhXztfrrFID7ORSXSzGZDwEcgcg1Qa4nBmIC7TXDV0ubfP
         oH097MlZHjtMRQm9CBznW2lh2hDWmb6nX0eHi/9X4rjbVMaBsPg039OT83yVNgPveoIz
         U/Jmfo+9+Ac2ebkSRXFiDBJVpmZKsBKMnxLx+1p3nLhAa5X9H+UscP54KywOR7+NAQxw
         dOLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :in-reply-to:mime-version:user-agent:date:message-id:from:cc
         :references:to:subject;
        bh=hKixGSb3cb49P/FLh50x6vu2LbncCdYZA1numUuCA+M=;
        b=bxvs+aTaxMOA6VFlq6F489+aZ4PTS9u6sq30JQK2dUjdcVXWw43rO8qy4CcFIuowwm
         sRb0Qjg0z8+bCZ+oU23BmSQRNRKyK1yzJp7kSzA95Ve8R3JA84otRhBv30fXrhJeLUmg
         gKxFd6w7jf5spkMIDkznf5k5xEjAKjFHAVuYDmnSJdQPxynXXg6cGrOI0uTivM3lbpEP
         ssVxju4lBVdKxd2Yvs6OIAMdfUf4W+LGThzxphxr7YZ4gG/78SiiTOX48Ff1786L9WPH
         c+Aklmru9Z8NgBLVMkbON/5Woe5Rtt4v4nhYQ7Yy1CtlIpXVDbO8Jg/rN3WH9mgJFi/E
         7xGw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=bZJLHdKc;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id lu24si2059711ejb.477.2020.07.09.07.59.40;
        Thu, 09 Jul 2020 08:00:03 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=bZJLHdKc;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726762AbgGIO7a (ORCPT <rfc822;uzarths@gmail.com> + 99 others);
        Thu, 9 Jul 2020 10:59:30 -0400
Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:7111 "EHLO
        hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726371AbgGIO7a (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Jul 2020 10:59:30 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5f0730660000>; Thu, 09 Jul 2020 07:57:42 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 09 Jul 2020 07:59:30 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 09 Jul 2020 07:59:30 -0700
Received: from [10.19.64.157] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 9 Jul
 2020 14:59:25 +0000
Subject: Re: [PATCH v3 3/6] gpio: max77620: Don't set of_node
To:     Dmitry Osipenko <digetx@gmail.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        "Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
References: <20200708202355.28507-1-digetx@gmail.com>
 <20200708202355.28507-4-digetx@gmail.com>
CC:     <linux-tegra@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
From:   Laxman Dewangan <ldewangan@nvidia.com>
Message-ID: <19c30bda-e1bd-7f24-dcd0-337d76abd6fc@nvidia.com>
Date:   Thu, 9 Jul 2020 20:28:53 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20200708202355.28507-4-digetx@gmail.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1594306662; bh=hKixGSb3cb49P/FLh50x6vu2LbncCdYZA1numUuCA+M=;
        h=X-PGP-Universal:Subject:To:References:CC:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding;
        b=bZJLHdKcmPygPxKev8etJRbK/J3vdh3ZNNAJrdKtjsZws4HBNzW2SeQY/hhGVqp4O
         gDQfOUl8FEigOW3YM/skB+HaXoNxfsQdWllnIk3x44eppSHPUkV8rQnyHx7VRbyRqo
         tCn055RGrKj/S3+3taVyFTtNzU9GqCUF6mAksjHcjYpJkx7SdhglzV/87HKfir/dbg
         WT+I/kdOtHGlVM9t3RdXJwZ+pXKi24mv2Vq0askC4USzhNuu0YzrtgLCp1aglMRgnr
         T/GG8dL7BgudFCLSEhOAJFj5Iwqr0kNNRZoEDzY9mJdginK7zMm0J+mt0UWANYD5mC
         yPyX7yjngI4bg==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Thursday 09 July 2020 01:53 AM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> The gpiochip_add_data() takes care of setting the of_node to the parent's
> device of_node, hence there is no need to do it manually in the driver's
> code. This patch corrects the parent's device pointer and removes the
> unnecessary setting of the of_node.
>
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>


Looks good to me.
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>