Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: PyMEWeA7NzssZmOeKHCRKmZjhc9Lg4zfvSn+qCpS8WiQgPcB6/JQ4I9DhTHNmdMcVJlCPN1STL
 vfyFGKl/WB8Q==
IronPort-SDR: mFl7tvzao2b3S+WOOm7EWaDgKCEOqP556h7rRjXy2n17GoOlSWUOaMw7fqxanx3U7Jnj7m54xx
 2CgmiOdsFUdg==
Subject: Re: [PATCH 05/11] perf intel-pt: Use itrace error flags to suppress
 some errors
To:     Andi Kleen <ak@linux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org
References: <20200709173628.5613-1-adrian.hunter@intel.com>
 <20200709173628.5613-6-adrian.hunter@intel.com>
 <20200709175046.GA1126680@tassilo.jf.intel.com>
From:   Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
Message-ID: <3271e2cf-490b-5391-19e0-e1b019bfba1f@intel.com>
Date:   Thu, 9 Jul 2020 21:13:38 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.1
MIME-Version: 1.0
In-Reply-To: <20200709175046.GA1126680@tassilo.jf.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/07/20 8:50 pm, Andi Kleen wrote:
> On Thu, Jul 09, 2020 at 08:36:22PM +0300, Adrian Hunter wrote:
>> The itrace "e" option may be followed by a number which has the
>> following effect for Intel PT:
>> 	1	Suppress overflow events
>> 	2	Suppress trace data lost events
>> The values may be combined by bitwise OR'ing them.
>>
>> Suppressing those errors can be useful for testing and debugging
>> because they are not due to decoding.
> 
> I suspect it will be useful to more than just decoding and debugging.
> 
> But the number is not a nice user interface.
> 
> How about e[....] 
> 
> like e[ol] 

Do you mean literally square-brackets? If you were really unlucky you might
get pathname expansion with that.

> 
> Also it's a bit unusual that this disables instead of enables, but ok.
> 
> -Andi
>