Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp35250ybt; Thu, 9 Jul 2020 14:44:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTxJy4wZ6HNPCO02qCvf1D6iaWEp2W/rjPJ2CHE36Etkp5T+Xh2nswlmBtsfDyHHaHQljJ X-Received: by 2002:a17:906:9348:: with SMTP id p8mr36700298ejw.467.1594331055558; Thu, 09 Jul 2020 14:44:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594331055; cv=none; d=google.com; s=arc-20160816; b=zptw3dWKAu88VTuOB8JUNuUX8YVGiBi4dFLHjaFHwOkdg2TLEM0gMgdt0mUceCI8t5 ZA2jUfxAr+v1bRy/vDLgLmL/qa5OP8ZtJbNoKlzMlqgu8fdtclM5cZeLigfMqsPHfqIs RiFPy6BZuooWPHs+6xRLRnyJujhkJJ7cnbQ/0acohxe8v+skIFJ8y+ax293SjaZqYg7n aCwmhnqAaJ00V3IQAM3B2HJt499M7Z0zpKQyDFMAFp01xstEZYGxcLKuIyWouIV8u3Iy aRgdbNYuDjCk1fBrga+smLLssLifMaZe6qCHuoQ7agvZq7s8zVTzEr1tzbg3mFWPLdlK ol0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=B5aqG+EQGURxxxY3kgfRBZogHwn4Xhg8KkXt1ACMF+A=; b=pjvZx64MQKV5SZYJtEkEUpEJx4XhuSkip3KGKWG+l8cECzfFb8p1LR/Y7xQiqcVODh A/OzDTuEIquLFZuRyI4RKfy8CP4l+4YwJTUCxUGdwOR+gyYBgpCMY44MiF/CsmHl/UjO FZNNLLtHywuPo3VHa451P6GQtWsOipnjgHQEUXB/k7u8UmIEoIbqk1LcVBmfKtHihRbc IoSNjiU41zwyBZenglrqLQubHW2NjPkrB9fBHIOoJx7qLa9L8sGqOtQdx9lwuMs7nz05 WvzFY1bXvMjAD93KvHGDl+CVolju3l1Oy2wqZ8QLYb9/wyW7ZdMbgOR1q9AYkTZkK82d 8hSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w13si2718108eju.736.2020.07.09.14.43.53; Thu, 09 Jul 2020 14:44:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726510AbgGIVni (ORCPT + 99 others); Thu, 9 Jul 2020 17:43:38 -0400 Received: from www62.your-server.de ([213.133.104.62]:33874 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726269AbgGIVnh (ORCPT ); Thu, 9 Jul 2020 17:43:37 -0400 Received: from sslproxy01.your-server.de ([78.46.139.224]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1jteKL-00029M-Gu; Thu, 09 Jul 2020 23:43:33 +0200 Received: from [178.196.57.75] (helo=pc-9.home) by sslproxy01.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jteKL-00085h-9X; Thu, 09 Jul 2020 23:43:33 +0200 Subject: Re: [PATCH bpf] selftests: bpf: fix detach from sockmap tests To: Lorenz Bauer , Shuah Khan , Alexei Starovoitov Cc: kernel-team@cloudflare.com, Martin KaFai Lau , linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200709115151.75829-1-lmb@cloudflare.com> From: Daniel Borkmann Message-ID: <98ec53fe-7766-2b0a-42f4-89ce9aad04dd@iogearbox.net> Date: Thu, 9 Jul 2020 23:43:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20200709115151.75829-1-lmb@cloudflare.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.3/25868/Thu Jul 9 15:58:00 2020) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/9/20 1:51 PM, Lorenz Bauer wrote: > Fix sockmap tests which rely on old bpf_prog_dispatch behaviour. > In the first case, the tests check that detaching without giving > a program succeeds. Since these are not the desired semantics, > invert the condition. In the second case, the clean up code doesn't > supply the necessary program fds. > > Reported-by: Martin KaFai Lau > Signed-off-by: Lorenz Bauer > Fixes: bb0de3131f4c ("bpf: sockmap: Require attach_bpf_fd when detaching a program") Applied, thanks!