Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4 2/2] devicetree: hwmon: shtc1: Add sensirion,shtc1.yaml
To:     Rob Herring <robh@kernel.org>
Cc:     Jack Lo <jack.lo@gtsys.com.hk>, devicetree@vger.kernel.org,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20200708040748.9014-1-chris.ruehl@gtsys.com.hk>
 <20200708040748.9014-3-chris.ruehl@gtsys.com.hk>
 <20200709165107.GB498064@bogus>
From:   Chris Ruehl <chris.ruehl@gtsys.com.hk>
Message-ID: <21a3f5a0-6f66-33d2-6def-725743cc67e3@gtsys.com.hk>
Date:   Fri, 10 Jul 2020 10:08:55 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <20200709165107.GB498064@bogus>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Rob,

On 10/7/2020 12:51 am, Rob Herring wrote:
> On Wed, Jul 08, 2020 at 12:07:47PM +0800, Chris Ruehl wrote:
>> Add documentation for the newly added DTS support in the shtc1 driver.
>> To align with the drivers logic to have high precision by default
> 
> If 0x70 is the only address, then do:
> 
> reg:
>    const: 0x70

yes, that make sense.

> 
>> +
>> +  sensirion,blocking_io:
> 
> s/_/-/

done!

>> +
>> +examples:
>> +  - |
>> +    i2c1 {
>> +      status = "okay";
> 
> Don't show status in examples.

Thanks for your advice.

updated and patch set v5 is out soon.

Chris