Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   Qian Cai <cai@lca.pw>
Mime-Version: 1.0 (1.0)
Subject: Re: [mm] 4e2c82a409: ltp.overcommit_memory01.fail
Date:   Thu, 9 Jul 2020 23:26:02 -0400
Message-Id: <6F39E573-C325-4D94-ABBE-E869E146B05E@lca.pw>
References: <20200710013852.GB81727@shbuild999.sh.intel.com>
Cc:     "Huang, Ying" <ying.huang@intel.com>,
        Andi Kleen <andi.kleen@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Michal Hocko <mhocko@suse.com>,
        Dennis Zhou <dennis@kernel.org>, Tejun Heo <tj@kernel.org>,
        Christoph Lameter <cl@linux.com>,
        kernel test robot <rong.a.chen@intel.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Matthew Wilcox <willy@infradead.org>,
        Mel Gorman <mgorman@suse.de>,
        Kees Cook <keescook@chromium.org>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Iurii Zaikin <yzaikin@google.com>, tim.c.chen@intel.com,
        dave.hansen@intel.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, lkp@lists.01.org
In-Reply-To: <20200710013852.GB81727@shbuild999.sh.intel.com>
To:     Feng Tang <feng.tang@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Jul 9, 2020, at 9:38 PM, Feng Tang <feng.tang@intel.com> wrote:
>=20
> Give it a second thought, my previous way has more indents and lines,
> but it is easier to be understood that we have special handling for
> 'write' case. So I would prefer using it.=20
>=20
> Thoughts?

I don=E2=80=99t feel it is easier to understand. I generally prefer to bail o=
ut early if possible to also make code a bit more solid for future extension=
s (once the indentation reached 3+ levels, we will need to rework it).

But, I realize that I have spent too much time debugging than actually writi=
ng code those days, so my taste is probably not all that good. Thus, feel fr=
ee to submit what style you prefer, so other people have more experience cod=
ing could review them more.=