Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: CQIaZkqwaRBwpS0YaOXKh3hyKkJbnLSVzK7VUy3E9cU2VQNXsKSEo2KaDbq7bDclVz9j+XFkG+
 l+tHPa/FX+WA==
IronPort-SDR: DYrjkeNDTDE+0PeUvDulaksFLuvo12c7J85VIUTELK0uiRi7Nz1XS0Icj/is35EfXwN680sZQg
 Dp9MAc6zN5OQ==
From:   "Wu, Hao" <hao.wu@intel.com>
To:     "Xu, Yilun" <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>
CC:     "mdf@kernel.org" <mdf@kernel.org>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "lgoncalv@redhat.com" <lgoncalv@redhat.com>,
        Matthew Gerlach <matthew.gerlach@linux.intel.com>,
        "Weight, Russell H" <russell.h.weight@intel.com>
Subject: RE: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
Thread-Topic: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
Thread-Index: AQHWVcomDnRuf5Ios0uozSMTJLBb7aj+8y7ggAAJzICAAAjeAIAAMHgAgAES8YCAAAzw8A==
Date:   Fri, 10 Jul 2020 06:14:19 +0000
Message-ID: <DM6PR11MB3819BF1B54D64AD706BF832E85650@DM6PR11MB3819.namprd11.prod.outlook.com>
References: <1594282705-32289-1-git-send-email-yilun.xu@intel.com>
 <DM6PR11MB3819117029F124067F7EA8B985640@DM6PR11MB3819.namprd11.prod.outlook.com>
 <20200709093527.GA32541@yilunxu-OptiPlex-7050>
 <DM6PR11MB3819D07348C347B5BB8F86C085640@DM6PR11MB3819.namprd11.prod.outlook.com>
 <2d7919d5-a320-58f4-5c9d-7ef868ad8676@redhat.com>
 <20200710052443.GB8689@yilunxu-OptiPlex-7050>
In-Reply-To: <20200710052443.GB8689@yilunxu-OptiPlex-7050>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.2.0.6
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e7cfd86-9ee7-4d7f-c97d-08d824987b7c
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2020 06:14:19.8029
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mpi1hs8lZD4U/diSJF3EqHoL53OI/DLUNqNbxnpmDvejOKsf8u4AlC2MD6TBG8wxJ7lHj5rMP0z0wPLmJL9PNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3545
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Thu, Jul 09, 2020 at 06:00:40AM -0700, Tom Rix wrote:
> >
> > On 7/9/20 3:14 AM, Wu, Hao wrote:
> > >> On Thu, Jul 09, 2020 at 05:10:49PM +0800, Wu, Hao wrote:
> > >>>> Subject: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC =
N3000
> > >>>>
> > >>>> Add PCIe Device ID for Intel FPGA PAC N3000.
> > >>>>
> > >>>> Signed-off-by: Wu Hao <hao.wu@intel.com>
> > >>>> Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> > >>>> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > >>>> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> > >>>> ---
> > >>>>  drivers/fpga/dfl-pci.c | 2 ++
> > >>>>  1 file changed, 2 insertions(+)
> > >>>>
> > >>>> diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
> > >>>> index 73b5153..824aecf 100644
> > >>>> --- a/drivers/fpga/dfl-pci.c
> > >>>> +++ b/drivers/fpga/dfl-pci.c
> > >>>> @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev
> *pcidev)
> > >>>>  #define PCIE_DEVICE_ID_PF_INT_5_X0xBCBD
> > >>>>  #define PCIE_DEVICE_ID_PF_INT_6_X0xBCC0
> > >>>>  #define PCIE_DEVICE_ID_PF_DSC_1_X0x09C4
> > >>>> +#define PCIE_DEVICE_ID_PF_PAC_N3000 0x0B30
> > >>> Should we drop _PF_ here? and also do you want _INTEL_ here?
> > >> I think we could keep _PF_, also there is no need to support VF of p=
ac
> > >> n3000 in product now, but it does exist (ID: 0x0b31).
> >
> > I was wondering about the vf id, thanks!
> >
> > >>
> > >> And add _INTEL_ is good to me.
> > >>
> > >> Then how about this one:
> > >>   #define PCIE_DEVICE_ID_PF_INTEL_PAC_N3000	0x0B30
> > > I am just considering the alignment with ids defined in
> include/linux/pci_ids.h
> > > So drop _PF_ before _INTEL_ would be better? : )
> >
> > To be consistent, all the id's are intel and all could drop pf.
>=20
> That's good to me after checking the pci_ids.h. So we have:
>=20
> #define PCIE_DEVICE_ID_INTEL_PAC_N3000        0x0B30

Sounds good to me.

Hao