Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp395510ybt; Fri, 10 Jul 2020 02:38:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzEKOYwO8WBsBNKVibCwfQSRHXOMKVbw71XYiwP6EkfdH6WMvgMnKDBubdk1s+cO0TNAg3 X-Received: by 2002:a17:906:46cd:: with SMTP id k13mr59152864ejs.312.1594373918458; Fri, 10 Jul 2020 02:38:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594373918; cv=none; d=google.com; s=arc-20160816; b=wUNC9gA2KD+6ctwxg8sGCI4E7Qt4aAzpXU5AXWDiTONj6wEYp+vvuvlkL61vKRgIGc pyhLKXM5Z+HOSbspxUcpLHFk/X+55Z+6h+qfCWg7HxEQO8a9zL/hQ58kESne3N2ugWU8 +MaqMgVV692MWXGtvs+o6hjZAKx3cdyG2wp+xBq/doVl263fZduzr6vwy2SDW9agfUHS zgYskrKhQ5ZXH6jy1h0Io0HWDBd0tGtIX4VkjQfBohm04Lycds7Z6Uy2048NeYBab4Nr 2z5kcX4POoClxOYTjDHYk0Ua1jJCL5itbvS8bdVSRtCLjrZcUigTdx/t5yXG/40giSwk gL8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=/dUk3o7WmxeQ+s81BEUdkgQmyRruCHvFWBCU6KJpmRE=; b=F+QheJsXAk/M4dKAPJKGEKFMs8l5ctVVH6YZUd8Vc0XkJ2cqBrJgjojQ7FnYSD7ru2 IoXudHZXs2vQugDKKg+OLXhf50xxNzZb4KF+zsx9kIJas+J/dTBxI6yLIcoM44s7YBMY sK2E12zuJt+2M2e2OkF9IaU/NxOEV9lLpWwwZI3YaIy/iahi1Bhxlne8I8C+3pPItgPN VMSCOHv+xxnpUTlucPhtwT02tU43NKKsKJgMx1QQE9QCGvjY5Wpcm8yQpXsGntaq1l+t t8BPGrsHAPdddTOCCDQnNAsSA2DNpztqGiOn8mDRqADXaFVaZ9KxV/GQyReKnc1v0R0V PoSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AygFhQyh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y8si3460064ejo.267.2020.07.10.02.38.15; Fri, 10 Jul 2020 02:38:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AygFhQyh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727066AbgGJJhk (ORCPT + 99 others); Fri, 10 Jul 2020 05:37:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726288AbgGJJhj (ORCPT ); Fri, 10 Jul 2020 05:37:39 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38D8FC08C5CE; Fri, 10 Jul 2020 02:37:39 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id r19so5673070ljn.12; Fri, 10 Jul 2020 02:37:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/dUk3o7WmxeQ+s81BEUdkgQmyRruCHvFWBCU6KJpmRE=; b=AygFhQyh7GIEUNYRy1O7/Ymb+5SKSUz6bVA1Js7C/JQDnOZd/ufSlMgXrJPJsM4sLb pCqLzyJqMCDE1R8lFz3p+dHtw1TwR0JFhBkbUflOVI7vsbKVPvudTqKpR/6afvz3EtvW 0MWUOC8hXf0JRHoGzU5mYK2AmwuSGqVQVuBv2/+HBXfW8x02g5akvkg//mlumE/qgAu+ ZZeLWpyNDYyW/qkQ8RTg4aSFsADbk9U0ZlOc+t3rxVU2/8znP1QgK3tHdV6TlqYO7e9f iifAuyzBIADOld7NFMvbG5aqVy7VL/tohaX2hGKtvEX+QxuJmhhR85T23Q7MZEnnzgD+ Mn/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/dUk3o7WmxeQ+s81BEUdkgQmyRruCHvFWBCU6KJpmRE=; b=kFaBf8+5laDdCNz3xO9lUl6VEEPUXMei1SmpyIZMdA1jAE1YMEziC4ASEB8hck/9XU 4h0dnWt4pV6xjZRS6Zp6SEKat97S6JcTkFO7savkMkg4giM7HcpPWLAEDTrZxPQ0N2VG gIpBmByqih99lcpfQLZcp3nHQirjDpke6kzg1yK34ggCOKEikW0yv4uVwld6HAZavcc7 0Vmgrm+mO+MX4NAV3s09PkU0hZ3QJ5UUpvrFYCYPWbfZKo8R8fm7uutxU4LZjKr6RbLA +m4MkglKo2x9FLPHHtCpddxRtyWbPY0acj1JY+EHLyEHcKijPM1wqJxy2jTpXWS7om4t 5ifw== X-Gm-Message-State: AOAM531OQtyt3tECLC9staGmdElyzdOVwpe+TbUQ4Z2AmGsGVWKBLNLz UkxYYaScOV4ZebzIVzaS0Cw= X-Received: by 2002:a2e:1502:: with SMTP id s2mr25083480ljd.236.1594373857641; Fri, 10 Jul 2020 02:37:37 -0700 (PDT) Received: from grain.localdomain ([5.18.102.224]) by smtp.gmail.com with ESMTPSA id 24sm1965112lfy.59.2020.07.10.02.37.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 02:37:25 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id E6A561A007B; Fri, 10 Jul 2020 12:37:21 +0300 (MSK) Date: Fri, 10 Jul 2020 12:37:21 +0300 From: Cyrill Gorcunov To: Rasmus Villemoes Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kcmp: add separate Kconfig symbol for kcmp syscall Message-ID: <20200710093721.GE1999@grain> References: <20200710075632.14661-1-linux@rasmusvillemoes.dk> <20200710083025.GD1999@grain> <14b4a1f0-3caf-75e4-600a-3de877a92950@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <14b4a1f0-3caf-75e4-600a-3de877a92950@rasmusvillemoes.dk> User-Agent: Mutt/1.14.5 (2020-06-23) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 10, 2020 at 11:05:11AM +0200, Rasmus Villemoes wrote: > >> I deliberately drop the ifdef in the eventpoll.h header rather than > >> replace with KCMP_SYSCALL; it's harmless to declare a function that > >> isn't defined anywhere. > > > > Could you please point why setting #fidef KCMP_SYSCALL in eventpoll.h > > is not suitable? > > It's just from a general "avoid ifdef clutter if possible" POV. The > conditional declaration of the function doesn't really serve any > purpose. OK, thanks for explanation.