Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp401885ybt; Fri, 10 Jul 2020 02:50:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzxqtaW3E922hFvZYaEE3yYCsXhpdYtkKfnEHQc8t7bNMTbzB30w6Ty8BdDw3ZTt9BC23r X-Received: by 2002:a17:906:3446:: with SMTP id d6mr54777556ejb.323.1594374645767; Fri, 10 Jul 2020 02:50:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594374645; cv=none; d=google.com; s=arc-20160816; b=QI8MmirAIWzN9zmZHpQP25KYIkE2vylpyncJZQoxhHokw0vzwzsN/68Rrhl8P3Yz4C pOSjvoMQlJdnwPIaa6Yk7b6Ix91M1F8fTzFYvJ+5k2aj/RL696yq8tMW+UJ3Ui001mg+ bfLFK9qcCeu2Jkc0pAFbzKb9N676NJvycYbVS/dgyzg86DjX2NWjmes76AI1xz35C3qY qZC3jD++ACu+jlTM3qeUv+1BQUMNDmtvHr1kh+aurIje6hjQSWONujdBZ1JhsNASzP1i 416Y6cnBEdqefbWi9YL//bSAtWD2EDw7WGV5K0FFF/AZOcZiQOnsYBSWyotMnREQwwpm iHuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=IQvdU3iRt56w7HpkGVuSwd8XeVDq7ZK+VynoX1ee5lc=; b=vYMwn45HL5IRDS2taBx2sAYhTh0y9ZWCTJIkZ88CDkwLXlcJ2LfLvyy1nnEUj0sAJ9 DC3Im2bmuqrF3bhS9dwzCPdz7BBBP3a+9x+RUDfdZ3Sj6myuHS+A4Zd2SIMELwbPiyl3 c06eYsEn5a4zVsB9TJHPw1kxcl9JZvXcVHV73wjEfngq6u6C93AiztO0xvTvar050ilj TEyvvxxF3K008BIhYd2JAcOtOGduSqHFx1FWJGiYB8yjA/lDW5AfYzXy8klWA/J26+Gt 0pS6kRiIz0hZKPaZVnYzx7Q4vCRgw7Ev0z7+HV2m0xa2fywwkDClveThV52CbMJXAHud kMwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Irx4KP3W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k23si3638550ejo.308.2020.07.10.02.50.23; Fri, 10 Jul 2020 02:50:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Irx4KP3W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726816AbgGJJru (ORCPT + 99 others); Fri, 10 Jul 2020 05:47:50 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:38988 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726288AbgGJJru (ORCPT ); Fri, 10 Jul 2020 05:47:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594374469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IQvdU3iRt56w7HpkGVuSwd8XeVDq7ZK+VynoX1ee5lc=; b=Irx4KP3Ww0ay4Lft3Wgabh3WwkWlF9sl+vQu+qV7QzVfQd2prcuikFNKNb+ynxYRi5CjSs RTtHvMTUdAukrx4RVYwqbz5Rcm/eSRBwh76uk93H8VZrNNctbLrLCthJ2P3Xf/vUO0Ct7Q f8pEe37pzT0JwOp0+ImIxfvONkX7cfE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-131-aWm8zGwqNZ-WDNJn0Vw6SA-1; Fri, 10 Jul 2020 05:47:47 -0400 X-MC-Unique: aWm8zGwqNZ-WDNJn0Vw6SA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 29C69800FF1; Fri, 10 Jul 2020 09:47:46 +0000 (UTC) Received: from T590 (ovpn-12-41.pek2.redhat.com [10.72.12.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1F49B6FEF4; Fri, 10 Jul 2020 09:47:39 +0000 (UTC) Date: Fri, 10 Jul 2020 17:47:35 +0800 From: Ming Lei To: Baolin Wang Cc: axboe@kernel.dk, baolin.wang7@gmail.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] blk-mq: Remove unnecessary validation before calling blk_mq_sched_completed_request() Message-ID: <20200710094735.GB3417252@T590> References: <969d0e9f637b2a0dbfb3d284abfbed6fc7665ea4.1593846855.git.baolin.wang7@gmail.com> <20200710082304.GB29262@VM20190228-100.tbsite.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200710082304.GB29262@VM20190228-100.tbsite.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 10, 2020 at 04:23:04PM +0800, Baolin Wang wrote: > Hi, > > On Sat, Jul 04, 2020 at 03:28:21PM +0800, Baolin Wang wrote: > > We've already validated the 'q->elevator' before calling ->ops.completed_request() > > in blk_mq_sched_completed_request(), thus no need to validate rq->internal_tag again, > > and remove it. > > A gentle ping? Reviewed-by: Ming Lei -- Ming