Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] arm64: dts: mt8173: Re-measure capacity-dmips-mhz
To:     Hsin-Yi Wang <hsinyi@chromium.org>
Cc:     "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        Rob Herring <robh+dt@kernel.org>,
        Devicetree List <devicetree@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Ikjoon Jang <ikjn@chromium.org>
References: <20200706083705.2343150-1-hsinyi@chromium.org>
 <71bc5fa2-0869-5d91-6bb8-e8d59176e19c@gmail.com>
 <CAJMQK-iGwXFwkvY_1nYiVQ6D-N5yU8YNqxeaSy-1XNMJHj1H0A@mail.gmail.com>
From:   Matthias Brugger <matthias.bgg@gmail.com>
Message-ID: <fe75ae59-99a7-3eec-b481-f1ec3264a86f@gmail.com>
Date:   Fri, 10 Jul 2020 15:34:29 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <CAJMQK-iGwXFwkvY_1nYiVQ6D-N5yU8YNqxeaSy-1XNMJHj1H0A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 08/07/2020 20:55, Hsin-Yi Wang wrote:
> On Thu, Jul 9, 2020 at 1:01 AM Matthias Brugger <matthias.bgg@gmail.com> wrote:
>>
>>
>>
>> On 06/07/2020 10:37, Hsin-Yi Wang wrote:
>>> Re measure capacity-dmips-mhz on elm and hana:
>>>
>>> cpu 1:  9502 DMIPS @ 1703 Mhz
>>> cpu 3: 16250 DMIPS @ 2106 Mhz
>>>
>>> ==> 740 : 1024
>>
>> I have some trouble to match the commit message to the actual patch. Commit
>> message talks about cpu 1 but patch changes cpu0. Where are the values of the
>> other CPUs?
> 
> Small cpu on 8173 is cpu0 & cpu1, while big cpu is cpu2 & cpu3.
> Small cpu: 9502 DMIPS @ 1703 Mhz
> Big cpu:   16250 DMIPS @ 2106 Mhz
> 
> 9502/1703 : 16250/2106 = 740 : 1024 (scale big cpu to 1024), and this patch
> changes the small cpu value to 740.
> 
> 

applied to v5.8-next/dts64

Thanks!


> 
>>
>> Regards,
>> Matthias
>>
>>>
>>> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
>>> ---
>>>    arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> index 70b1ffcab7f0..5e046f9d48ce 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> @@ -167,7 +167,7 @@ cpu0: cpu@0 {
>>>                                 <&apmixedsys CLK_APMIXED_MAINPLL>;
>>>                        clock-names = "cpu", "intermediate";
>>>                        operating-points-v2 = <&cluster0_opp>;
>>> -                     capacity-dmips-mhz = <526>;
>>> +                     capacity-dmips-mhz = <740>;
>>>                };
>>>
>>>                cpu1: cpu@1 {
>>> @@ -182,7 +182,7 @@ cpu1: cpu@1 {
>>>                                 <&apmixedsys CLK_APMIXED_MAINPLL>;
>>>                        clock-names = "cpu", "intermediate";
>>>                        operating-points-v2 = <&cluster0_opp>;
>>> -                     capacity-dmips-mhz = <526>;
>>> +                     capacity-dmips-mhz = <740>;
>>>                };
>>>
>>>                cpu2: cpu@100 {
>>>