Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp550607ybt; Fri, 10 Jul 2020 06:42:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMypneIlq3egAK0Z8ZC98Q6Vf5w6bTpKPKD5VTXVPKqtql6msMfvFrjsUuAch0vXQJAEa1 X-Received: by 2002:aa7:c2d7:: with SMTP id m23mr14655331edp.216.1594388560300; Fri, 10 Jul 2020 06:42:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594388560; cv=none; d=google.com; s=arc-20160816; b=ZYJr/Bt6ivXBQwl2keSlcYS116KFrrNuxgZii5m612MEzs5riRVx3Gkd5+j9OCTKTL Me5BO6QRz86w6t3nOI5Nt4jCqS5Vr5AVzYfYwOCgqOUYej35WPuBaIeki77zeI4MslJA G6BFVKVl5B1e6aAwstGUnqaMzhmfC9gU0SkTJ1nHkLtm0bH+lWZp4B9W5NCdemtElmuM No7rdMxNoIAfsA/2S0cg9w28DfZpW7l2U++Hh4JOML0EqER2Ybh1FdBBOsloTWxHxs+q KjJZ1fRSIanHpkJvDVYPRVOXJTsBhY8pnz0dInY+Xlv8Vc6vzFNBBlr3RQ3JMNkYjlms 2SkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=i75CBXIgGhcZUa4Q5eVv78+LmWfKj2lmU+kA47/adfU=; b=akUOT+q/PPFTuLk8u7liZkickEpVH3yki4eKlNaGN+Am7FRkfo4ah8NjpFMRpQFkbs ccgnqlK+BE4MRk5uCOq1W4qqeXAtmeposb8CdBb61oHwK2QWS8b9dk1Wlm2kshZehEH8 fEw6QlO1molvt4eT+fy/xmnCs7LlEasdXEY7w1GxgqyvL5F8XO7YpbWNhOfbNmJ6R3hC ywrCR8XsXoMhIAxQspLlUkGWBtWFmIRH5G42WhgUrCR27Am7eBlwwFyDmnMb8qIMl+Kt zbBgypdmehgBhle74AokdePw91Q727b37yrC6jndclq2kkkZMozdhQfilHP6FVTSRy9Q V7Pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BVP2jY9B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b7si3901522eds.524.2020.07.10.06.42.04; Fri, 10 Jul 2020 06:42:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BVP2jY9B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727935AbgGJNlo (ORCPT + 99 others); Fri, 10 Jul 2020 09:41:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:37962 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726774AbgGJNln (ORCPT ); Fri, 10 Jul 2020 09:41:43 -0400 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 95917207DF; Fri, 10 Jul 2020 13:41:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594388502; bh=i75CBXIgGhcZUa4Q5eVv78+LmWfKj2lmU+kA47/adfU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=BVP2jY9BJ54jjApBEPD0xvCJ3d7zT7Oyt4yCdw6oxKWIRmgnSMcGpIU28L0X3wCxh bXzut1P37bZxexmGGjWs8ERCJodOW/vggL3EuRUxtOy4TZBDtPsFf8/2Lxaz6AIvYX 2BbnS0Pdbqa9ra4kz6hbuXtlqtqQ4nbR47BzrjBc= Received: by mail-ot1-f51.google.com with SMTP id h1so4179773otq.12; Fri, 10 Jul 2020 06:41:42 -0700 (PDT) X-Gm-Message-State: AOAM530r2+Cz20n1SpT+xeudNBFl0PqXzFDpPWvhjHJxIkTRQOhXAmYS 52xXlgRGrJjKt0kTaFIKzgrMHWGS3tEPsBxuvN8= X-Received: by 2002:a9d:7553:: with SMTP id b19mr11274563otl.77.1594388501943; Fri, 10 Jul 2020 06:41:41 -0700 (PDT) MIME-Version: 1.0 References: <20200610141052.13258-1-jgross@suse.com> <094be567-2c82-7d5b-e432-288286c6c3fb@suse.com> <170e01b1-220d-5cb7-03b2-c70ed3ae58e4@samsung.com> In-Reply-To: From: Ard Biesheuvel Date: Fri, 10 Jul 2020 16:41:30 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] efi: avoid error message when booting under Xen To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Cc: Bartlomiej Zolnierkiewicz , xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Linux Kernel Mailing List , Peter Jones , linux-efi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Jul 2020 at 16:38, J=C3=BCrgen Gro=C3=9F wrote= : > > On 10.07.20 15:27, Ard Biesheuvel wrote: > > On Fri, 10 Jul 2020 at 13:17, Bartlomiej Zolnierkiewicz > > wrote: > >> > >> > >> [ added EFI Maintainer & ML to Cc: ] > >> > >> Hi, > >> > >> On 7/9/20 11:17 AM, J=C3=BCrgen Gro=C3=9F wrote: > >>> On 28.06.20 10:50, J=C3=BCrgen Gro=C3=9F wrote: > >>>> Ping? > >>>> > >>>> On 10.06.20 16:10, Juergen Gross wrote: > >>>>> efifb_probe() will issue an error message in case the kernel is boo= ted > >>>>> as Xen dom0 from UEFI as EFI_MEMMAP won't be set in this case. Avoi= d > >>>>> that message by calling efi_mem_desc_lookup() only if EFI_PARAVIRT > >>>>> isn't set. > >>>>> > > > > Why not test for EFI_MEMMAP instead of EFI_BOOT? > > Honestly I'm not sure EFI_BOOT is always set in that case. If you tell > me it is fine to just replace the test to check for EFI_MEMMAP I'm fine > to modify my patch. > Yes please