Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] io_uring: fix memleak in io_sqe_files_register()
To:     Yang Yingliang <yangyingliang@huawei.com>,
        io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20200710141420.3987063-1-yangyingliang@huawei.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <65c82eaf-3f95-9280-3dc4-25b9e0781213@kernel.dk>
Date:   Fri, 10 Jul 2020 07:51:18 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200710141420.3987063-1-yangyingliang@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 7/10/20 8:14 AM, Yang Yingliang wrote:
> I got a memleak report when doing some fuzz test:
> 
> BUG: memory leak
> unreferenced object 0x607eeac06e78 (size 8):
>   comm "test", pid 295, jiffies 4294735835 (age 31.745s)
>   hex dump (first 8 bytes):
>     00 00 00 00 00 00 00 00                          ........
>   backtrace:
>     [<00000000932632e6>] percpu_ref_init+0x2a/0x1b0
>     [<0000000092ddb796>] __io_uring_register+0x111d/0x22a0
>     [<00000000eadd6c77>] __x64_sys_io_uring_register+0x17b/0x480
>     [<00000000591b89a6>] do_syscall_64+0x56/0xa0
>     [<00000000864a281d>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
> 
> 
> Call percpu_ref_exit() on error path to avoid
> refcount memleak.

Applied, thanks.

-- 
Jens Axboe