Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp602366ybt; Fri, 10 Jul 2020 07:52:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwba+8s1my7L/GLADcA0SArgaf57vAkXHKdYRyUiuQ8hqeZqnUUhMQFrYxEqOIfrcf0VdqT X-Received: by 2002:a17:906:355b:: with SMTP id s27mr64698523eja.368.1594392765982; Fri, 10 Jul 2020 07:52:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594392765; cv=none; d=google.com; s=arc-20160816; b=nI7N+eWSOwrST4zWXKy5NyempKW0iwHrpy3gaCKtMMqFkR3cmKXTGhSORXWJfxhuzS vd+ABnv3c/WN3ma1JMo6BXHVGxvlc0yL9thrweM63HssvfFBOtTdHmqXEKNgnFc2xHu3 ydfU72mWzWVKfTOD38J9aEZiF8q6WeqSa78VDFDu4sdcnK7WxxOkz58ISQrWHOnKXHGZ VHXiThcZax12mxV97rOyf8TUlaFu/Vv0jDgMeQ77R18mARyQsOmRxAoBUY3a/DP5nAHg 1Hh8LsCvhDKUn3S9Yqem/khKm/bnhCtvRgr3A6U2ZilTGPhdajgYS/VYC1F9UA4v0PHW NN/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=w0L02eYp2FXJKKzBL1qGWhW4jXZNBM3c5JNgOSVLBJk=; b=lMwAS81QIWsweSQ/99V/beFwbci9AOXj64rA76RFzkUpAGI38HCeSY9H1AwII7mOxn 2xjsn6KdJ1bcBsT477ylfB2wUMCmi+ryoIBIFhENbEbYTptYZpfwEH4dVFvG9DCqs8MZ 1cpytmlAjp1dMAo5e9J885n/+dDd2m2mXlt+Uij++Cl+efA/ZeTUG1pDftaUtJxkDJaY 5fspG3vDtNCCT1CfOUaiBBiwJrTmkGob026lvpjt5a9PBbPO+oh78SwObKUlMnYyYXIA oKpXjz05xOImRjo4fw1bTnxr8IjN2/Nqa5pcvEFEtbcRGVAy9AE9qL+cHv9K2R+3EqSE HogA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dt21si3958743ejb.402.2020.07.10.07.52.22; Fri, 10 Jul 2020 07:52:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727003AbgGJOtx (ORCPT + 99 others); Fri, 10 Jul 2020 10:49:53 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:40388 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726828AbgGJOtw (ORCPT ); Fri, 10 Jul 2020 10:49:52 -0400 Received: by mail-ed1-f67.google.com with SMTP id b15so4854607edy.7; Fri, 10 Jul 2020 07:49:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=w0L02eYp2FXJKKzBL1qGWhW4jXZNBM3c5JNgOSVLBJk=; b=UvgrXf5crwKKj2uiVPkPMutLBdqWE/GldZhbRjSchQeN74T/q0ORywzwjYggXkua6O Gn0ytfAkLWz9YQkP14KzGbU1gLXYBmC7TWFnuilt0T23wwONI6IWe7Cz70LldZQYtcTI b24Rbt8Its1XyJ/Ps0YHluIV5OH7XLs7Y+vmrfHxkszgSgmYyNyuZ9HIx3bnzJw9Zz4P lTxsduY1bwgvEKOpIOx2eWa4724n76UMIWE7FmQKNIlHia0A5FxrVY/gKXyDqkbt8EKP eaEgkP53tM1Pp7ceot6xyOHSfOiHzwVqFI7FkzfiNdKZF8SDExV3QYr0tT3J/C5GTTX8 Qnog== X-Gm-Message-State: AOAM533NOv4klJHdYsObRbX1AuSZbuVRU13RGgIfPk7XxLH875CcFQrA cfkX7Vzj0LYTFfdjlwE8vzc= X-Received: by 2002:a50:9a82:: with SMTP id p2mr76216460edb.130.1594392590723; Fri, 10 Jul 2020 07:49:50 -0700 (PDT) Received: from pi3 ([194.230.155.195]) by smtp.googlemail.com with ESMTPSA id e22sm3848826ejd.36.2020.07.10.07.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 07:49:50 -0700 (PDT) Date: Fri, 10 Jul 2020 16:49:47 +0200 From: Krzysztof Kozlowski To: Lukasz Luba Cc: Marek Szyprowski , Chanwoo Choi , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, willy.mh.wolff.ml@gmail.com, k.konieczny@samsung.com, b.zolnierkie@samsung.com, chanwoo@kernel.org, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, s.nawrocki@samsung.com, kgene@kernel.org Subject: Re: [PATCH 1/2] memory: samsung: exynos5422-dmc: Adjust polling interval and uptreshold Message-ID: <20200710144947.GB23140@pi3> References: <20200708153420.29484-1-lukasz.luba@arm.com> <20200708153420.29484-2-lukasz.luba@arm.com> <20200710131921.GA23039@pi3> <4bfa227e-3a6b-dfe2-140b-b402dea52231@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4bfa227e-3a6b-dfe2-140b-b402dea52231@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 10, 2020 at 02:41:28PM +0100, Lukasz Luba wrote: > > > On 7/10/20 2:19 PM, Krzysztof Kozlowski wrote: > > On Fri, Jul 10, 2020 at 03:13:18PM +0200, Marek Szyprowski wrote: > In such case, maybe as you said, let's switch to polling mode > > unconditionally? > > I can make happen that the polling mode will be unconditionally > set as default. > > Do you think that the interrupt mode code can still stay in the > driver, because maybe in future could be fixed? How interrupt mode would exist in such case? Or rather: how would it be used? There is no point to keep dead code and code once removed, can be easily brought back. Best regards, Krzysztof