Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp768548ybt; Fri, 10 Jul 2020 11:52:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpoAQdJMcrO+MhTDEJX3TYAJQWexeuw4Kwd3cehyfJfSfG7czePpMSVF2sjz8mYwNUATe4 X-Received: by 2002:a17:906:8392:: with SMTP id p18mr66045009ejx.24.1594407160180; Fri, 10 Jul 2020 11:52:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594407160; cv=none; d=google.com; s=arc-20160816; b=rv9LpM6GeW+6QgycxjPjifNDW3N1WR7XuPc6MY5c1k/gxILncI1ZEf6iHfxxUkdEnc ixsJm5jtq0Jod5VSSzmdbsdCpzPjnyfhpA4ZqL9wc5RUetYZ0jZ/KqYQzGS5G0gIYKfM eCoM5gy64aTF0YAHOe2dcFtVBbyZSp/Vswz0MwOhUufK1I9bcfVHQqynXD8xGdv93qDi sEtudfcHp75zgk6gFD7ikHBbxXqzb/zem0iQwhNrLnWtpNXhnoN/msMvZca7EmmmmZFF ooePWfaMCnIebjfh4KGN1g0xIzrz5SLiWOyGaHKYy08Lt/op+lllqn2fhiK4tDefblJt 7jTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Mb9O2vonY58SmLkrA3ALuyeYbHan5/59dl3EopR+4JI=; b=vP8cdsvHEhYzrkyGv/cgs7xE6Zc+eKxAWWfDUrLyiYz9lGaWMGCbgb42PmDpZarvRX MWODRnHhpD+OiYQRpN8GfwoJWd7jMmLpLkx2BBkpO1c7oC6pAtlGaer/HxIDVwoayqz6 JW3Fw/68X06Y2/f0+R/0sNoLEs5UFIRegyffRypjbI+weZfHqRRBix2jX9SfgdjKwPWL 43XUZSfp0vT+NeWLhDKC0Qecd+GLf8cMSDLzwNAKbg1Xo/H9LNycTEZb6mpWmg+1Y3iq h6j/CxQHuCVGrgC54mLwN4yS2MgB+vqzhv4Lj6NazIqQdDRAioQ2mpobKl6KvwM6bAa3 duEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=TXrXcnxK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n6si4359531ejc.328.2020.07.10.11.52.17; Fri, 10 Jul 2020 11:52:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=TXrXcnxK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728212AbgGJSwF (ORCPT + 99 others); Fri, 10 Jul 2020 14:52:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728003AbgGJSwC (ORCPT ); Fri, 10 Jul 2020 14:52:02 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67EF0C08C5DC for ; Fri, 10 Jul 2020 11:52:02 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id d10so2618977pll.3 for ; Fri, 10 Jul 2020 11:52:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Mb9O2vonY58SmLkrA3ALuyeYbHan5/59dl3EopR+4JI=; b=TXrXcnxKeeytSI744NwwayynrsSw5XkLlrMUku+ZJ9lCRP+fqO8/uh5+RqffjiJrXE z7D39x700Z7u5J8Bvh/KbH0pD3iXeAwzCBsarSibgGL/sMg1qvJ1zb0yDDW5utUeUkus sUOunu6eHh9IuBkOdk7DUEOImLHM8qT9H/QuU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Mb9O2vonY58SmLkrA3ALuyeYbHan5/59dl3EopR+4JI=; b=VlLiQHAvNkW/YmVWKn+li8PR5c9QXhrWBiD6ue48YD/ZISA/WSrsYEMNHpNGTEqNw6 y6sxzUUBgKDNPKOcgcJCwBTmTII3by01lI7nbktns92bIjPxLc9nPqTKvnPp37GUtckp IX53LOnLFXTNoNppPQ+FWHlCUN0K9KczNSEW4y6CXkkSYETTys+mqtBMDxIX95NKrgai jvQoXV3EjB1BjqOYWDzKjDDGJPnwe6KWdv0v5vTUNPPMBK3b66ydB4Vrf1wXWH3SPYkY Z6L/uihY1sPQ+iQLZ3PmIT9qavXOzXN+PnMm+U+/NyyBGN0kvMf4ek0RBcwWDcJ538LH Pm0w== X-Gm-Message-State: AOAM531utUxpxh0/ABGZqroKv6OgLx1gdl03NTVywonk092r7KjxXnei NpjW7o+LcJUMwrQT1UAwE6WIQQ== X-Received: by 2002:a17:90a:e602:: with SMTP id j2mr6867543pjy.200.1594407121965; Fri, 10 Jul 2020 11:52:01 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id o42sm6776191pje.10.2020.07.10.11.51.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 11:51:59 -0700 (PDT) From: Kees Cook To: Will Deacon Cc: Kees Cook , stable@vger.kernel.org, Tycho Andersen , linux-kernel@vger.kernel.org Subject: [PATCH for-next/seccomp 2/2] selftests/seccomp: Set NNP for TSYNC ESRCH flag test Date: Fri, 10 Jul 2020 11:51:56 -0700 Message-Id: <20200710185156.2437687-3-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200710185156.2437687-1-keescook@chromium.org> References: <20200710185156.2437687-1-keescook@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The TSYNC ESRCH flag test will fail for regular users because NNP was not set yet. Add NNP setting. Fixes: 51891498f2da ("seccomp: allow TSYNC and USER_NOTIF together") Cc: stable@vger.kernel.org Signed-off-by: Kees Cook --- tools/testing/selftests/seccomp/seccomp_bpf.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c index 08bfbb7fc1c2..93de2f1e3a99 100644 --- a/tools/testing/selftests/seccomp/seccomp_bpf.c +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c @@ -3238,6 +3238,11 @@ TEST(user_notification_with_tsync) int ret; unsigned int flags; + ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0); + ASSERT_EQ(0, ret) { + TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!"); + } + /* these were exclusive */ flags = SECCOMP_FILTER_FLAG_NEW_LISTENER | SECCOMP_FILTER_FLAG_TSYNC; -- 2.25.1