Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp851022ybt; Fri, 10 Jul 2020 14:11:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmjvjWy3DcYT2uOF8quIkSYSL3KNj9DS13PXkYyBbGGXKgr/4An3JWnZyVBByj3P9hFVSE X-Received: by 2002:a05:6402:22d5:: with SMTP id dm21mr54308168edb.26.1594415477318; Fri, 10 Jul 2020 14:11:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594415477; cv=none; d=google.com; s=arc-20160816; b=Jj1ebNPrtjwfajvAfuLj20vJ+5Eoi339FFf36fCgy0g7THP+htwKfAMlK2Q/JKDPHa htHkoLCfGKISIls2ULho9XGwwEmQfIAJ1u1dlmNG/MZGRIVEsReqwpg+O0vz+dxVA1IS 8ULZnldzI2XZoftxW8yNF9rewxzRVVJaFrVP0lPXBmQhCKoZ+298wycGULA4YbxZVR0D /StAqSJj8Y81wfKJh3qmr9ZnoZzOjGdfqW5krVtpDJ3Gbn6jhrVUvmrkajee6wavI0H/ L3LCRb7W8rdZUf5h8KJevIjJcgJS9Z/xcz0loTc8MDK/MfLxUbPJ9bFBxU60T2OEaC3l UUlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=P/4HJ6i3NSI/L4SNujzc0K7Ynl121/4NwIbrgrFwujw=; b=n4R2Mj3If9XW/C4ZFuVyXFcJfJ9xwtm24umEdmd3HZnEfrgBgjysErkDtA0dX0IlDJ WcHZf/ByOJlN6qppfB28xLIj/E5wm7vBxodP/De0KJcBcRtyAD2q+JHShHeHiaPVNj2z FYmDU8jKnpaJDMC4JlXU67Upc3aoQAZ8FbCjjiGRMFSIuPb5LXmz0I2YHvJWmrXBrIXN tjYmkWPqiUxgup657bXvYDJBp81E+4FVbO7TmWP0FGGNL4k9ox6YjFHB5PFUL4frCiz6 ZLlG58z1NDefCy/7Pd9BJhnIZ6AcTSpd3K+1lURaToTK+Ki9s2JsX04SPQivZHUDaIsG MuSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lg19si4740424ejb.138.2020.07.10.14.10.53; Fri, 10 Jul 2020 14:11:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726291AbgGJVKQ (ORCPT + 99 others); Fri, 10 Jul 2020 17:10:16 -0400 Received: from foss.arm.com ([217.140.110.172]:40532 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726129AbgGJVKQ (ORCPT ); Fri, 10 Jul 2020 17:10:16 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7A6B41FB; Fri, 10 Jul 2020 14:10:15 -0700 (PDT) Received: from [192.168.122.166] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 226F93F9AB; Fri, 10 Jul 2020 14:10:15 -0700 (PDT) Subject: Re: [PATCH 0/4] dma-pool: Fix atomic pool selection To: Nicolas Saenz Julienne , hch@lst.de, Robin Murphy , David Rientjes , iommu@lists.linux-foundation.org Cc: linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20200709161903.26229-1-nsaenzjulienne@suse.de> From: Jeremy Linton Message-ID: Date: Fri, 10 Jul 2020 13:52:59 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200709161903.26229-1-nsaenzjulienne@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I have merged this to a 5.8 tree along with "dma-pool: Only allocate from CMA when in the same memory zone" and tested it in various ACPI/DT combinations, particularly on the RPI4. It seems to be working fine. So thanks for your time and effort clearing this up! Tested-by: Jeremy Linton On 7/9/20 11:19 AM, Nicolas Saenz Julienne wrote: > This is my attempt at fixing one of the regressions we've seen[1] after > the introduction of per-zone atomic pools. > > This combined with "dma-pool: Do not allocate pool memory from CMA"[2] > should fix the boot issues on Jeremy's RPi4 setup. > > [1] https://lkml.org/lkml/2020/7/2/974 > [2] https://lkml.org/lkml/2020/7/8/1108 > > --- > > Nicolas Saenz Julienne (4): > dma-direct: Provide function to check physical memory area validity > dma-pool: Get rid of dma_in_atomic_pool() > dma-pool: Introduce dma_guess_pool() > dma-pool: Make sure atomic pool suits device > > include/linux/dma-direct.h | 1 + > kernel/dma/direct.c | 2 +- > kernel/dma/pool.c | 76 +++++++++++++++++++++++++++----------- > 3 files changed, 56 insertions(+), 23 deletions(-) >