Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp903328ybt; Fri, 10 Jul 2020 15:44:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy5fW9Pn7Oc2EydPwCTNg73MZ2y+C22OQWaM+4PSJcqAM2Purb5Uo96C1+2UJxqwKK0MXQc X-Received: by 2002:a17:906:3b15:: with SMTP id g21mr61088940ejf.221.1594421077946; Fri, 10 Jul 2020 15:44:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594421077; cv=none; d=google.com; s=arc-20160816; b=F/koPnEsyC3bY8rancNJGmEQSeTU/owOaiLF+zY2CuvxNI+7yGO13Hel6ICr2WoEZT 8ypBvPDD93hQ5Rod/h+g286ky+8iCcj+/RsQCzOocylPwgaeK5bscNyLISnbLRQAAIHK /3Q6/a6d0zEdWjBmu0T3UY3WDNCSq0v9obiSvjoP1CMTI8jevE0FyCYeG2c6NOoH8xRk H876P5+xeUtmDrWGskbqbuicONa31cNoRiUkV98PIK6BinIJot75BxKe2P2oCTWhYsYk VRyrn/wpOaGM2oezmzQm/gAz/+yLO/tsCcMBSeqcLXNwLGRoj0L6S9uRkpoNfOfWHLde yDhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=+thtRKJEj4DhIkEI6p+GkkTjAsDSYTDkX8oKURyOcGc=; b=Q13wM2DzYmd3MmlQq69JYbZtWDEwIlxVYmJJZhlyufYzcwDgKykLI99jpYkvvIAU/c kU4dzbFSBZs0y4891tHUmoxj8h5WpKjePyfu9WDV3w7L1KXp90r1m0VTr/oT69toQrW5 zt1tTumOQGWUcRtUhkcgg62szFk9vniea7XARpiGAIm56/vdPOz8o/FeIJJcFDuiQ84L 5fsj0XRbM9NP7mCWfL221tGZej9En+Z7rfd6w7eF2duqZl/Ach8JkgUGyfwuWckgLuWU hwx1R8IRaJzHeJXli/oJqDEfhh5VFrjcRjH1rBcIQJPWqjpItJ5c1YP9qLz76dzEmjQD PuFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=EGO2snRn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p27si4810251ejd.590.2020.07.10.15.44.15; Fri, 10 Jul 2020 15:44:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=EGO2snRn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726661AbgGJWoD (ORCPT + 99 others); Fri, 10 Jul 2020 18:44:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726369AbgGJWoC (ORCPT ); Fri, 10 Jul 2020 18:44:02 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80A8EC08C5DC for ; Fri, 10 Jul 2020 15:44:02 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id h19so8109928ljg.13 for ; Fri, 10 Jul 2020 15:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+thtRKJEj4DhIkEI6p+GkkTjAsDSYTDkX8oKURyOcGc=; b=EGO2snRnxuL6RoH27XeBowczxmsAaLfO6uLpBlMOy45LATMKOWSFFk1IrSjjsXFz2v rNlXSeDKRIbt38tUxq7xLAWLsXI6Wf+wbETMPA63v2Z/YsrZH01CZAC5MYeCWgJOletJ O9AL8l7WpdulV3yDBrfd+PUo1fjJNcFW5TnuE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+thtRKJEj4DhIkEI6p+GkkTjAsDSYTDkX8oKURyOcGc=; b=A96HFNL0X+qaq+Yri9ILmKOUwAmAEzx7VrlaL4JepvCUtLo591dOMuzhiIRWu+q5ad ipGLGFLqa46Izixgvaoz/D8gUMsY8u4/mMZCXyVndxqKFBPMxNKGlLmpqZ1HqKuObs0t /T3D7l9fIlrRx1F/1WRIvZvSLI0QCFxFTQJumJPhDun9BOguImq/SArrseMsp4HxgaY0 z8+W9mygWjYJECIG2K+LJTuY9e+e5OvDDr6TxTzaQycuFCv5AYBIegUbApFiTelp6aHS x6l9hiPMU1ihn+hf2VHBpRvnXgX9n29tINRxm/wSGCDU+hw2jVFQ3B6FM9oVKNu82eS6 qAuw== X-Gm-Message-State: AOAM530FW1y7cENbpzPFvNtMHIQtaskWb7rf33wOeg0BkWVBBmAQAqeg m8CAHRekrPBHqt1FzXk9gdEajiRS+HA= X-Received: by 2002:a2e:954c:: with SMTP id t12mr40834896ljh.287.1594421040640; Fri, 10 Jul 2020 15:44:00 -0700 (PDT) Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com. [209.85.208.176]) by smtp.gmail.com with ESMTPSA id q1sm2338750lji.71.2020.07.10.15.43.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2020 15:43:59 -0700 (PDT) Received: by mail-lj1-f176.google.com with SMTP id q4so8180355lji.2 for ; Fri, 10 Jul 2020 15:43:59 -0700 (PDT) X-Received: by 2002:a05:651c:1b6:: with SMTP id c22mr36397087ljn.421.1594421039353; Fri, 10 Jul 2020 15:43:59 -0700 (PDT) MIME-Version: 1.0 References: <20200709221102.323356-1-cesarb@cesarb.eti.br> <20200710223441.756320-1-natechancellor@gmail.com> In-Reply-To: <20200710223441.756320-1-natechancellor@gmail.com> From: Linus Torvalds Date: Fri, 10 Jul 2020 15:43:43 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mips: Remove compiler check in unroll macro To: Nathan Chancellor Cc: Linux Kernel Mailing List , Cesar Eduardo Barros , clang-built-linux Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 10, 2020 at 3:34 PM Nathan Chancellor wrote: > > Clang 8 was chosen as a minimum version for this check because there > were some improvements around __builtin_constant_p in that release. In > reality, MIPS was not even buildable until clang 9 so that check was not > technically necessary. Just remove all compiler checks and just assume > that we have a working compiler. Thanks, that looks much nicer. Applied. I think we could probably remove the (unrelated) clang-8 check in the arm side too, but I guess I'll let arm/clang people worry about it. Linus