Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp974761ybt; Fri, 10 Jul 2020 18:12:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwlzCw0kVK7E1NRY1t5jPe1aXmT7+eIi8rGj6c/+yrSsvOVWb35rvjIbMJs5eZGwd/1SK4b X-Received: by 2002:a17:906:8688:: with SMTP id g8mr62640297ejx.505.1594429934710; Fri, 10 Jul 2020 18:12:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594429934; cv=none; d=google.com; s=arc-20160816; b=x7WLHJQFqanstf4GahajMP0DnqtLU/VkBJKB6uUULh3WlOUybNxDJ7O2LHxZ9ldmXK yM4NQGWTNZCYv9BDmFyGgfXGrPVfoezy9vHGyeknXZlZ2kK6Poj5KHMZK5cWJbPxDnVC JyUO9IP8zWOjJv9uFxa/INqha4pqzgmLLCbp48XjwmAj0EBkPwkjjtLbgWYenuZEuqFb h1JY/Hb0R6I9tQQ5qH8gUuBvvirSo/qy7TcDmzDGrtU6eJplorgIWz5FhATSCn5lgkY+ KywKkNrpMRM+uKoMNS5+qDNOPRGrVTfB3lzMWxIbsp1w6+hkkOLmupvvJXewuxh+kOtS WMIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=E5EhZSSQ3JEvbwDQYx3nByG/5i8ReqO0UBb3fyfrXk8=; b=PSySZa2IIgImGDEIejvsVonywKJCkc8rKw16LO60FpKrqnQiIQMs69AelCFbbbq6Cd 9Z8FlITniNmF6MtgEB92s1dis3eqxT/c+ei961Pd49iYoQKHYsrGiFzpA6wWILIelmFO RtLunGl2LsMp/C3RBiM/jFuzfTr3q9GzK7NscgUfgjwTzsOCD/zjMDc7ZDqH0E+dghIa Zfk9MYvWuLbNnaTfTbvtMVjQpLhylDdsB3RjKmwinBJSqAuTcAy/zPlSJrpVPpIuCQJA R/49dCnixqPDTOseU8iU2BMtmox5ONCGI02O81y2/SXqbh1aP2kEOVimufdxRElZJnt3 i6Nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ua2kf3VZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dr9si6658638ejc.147.2020.07.10.18.11.48; Fri, 10 Jul 2020 18:12:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ua2kf3VZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726671AbgGKBKg (ORCPT + 99 others); Fri, 10 Jul 2020 21:10:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:37982 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726328AbgGKBKg (ORCPT ); Fri, 10 Jul 2020 21:10:36 -0400 Received: from wens.tw (mirror2.csie.ntu.edu.tw [140.112.194.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8B3AD2076A; Sat, 11 Jul 2020 01:10:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594429835; bh=obkdWl2N6bzEnN0PanxeRIISOXyw6TIbMvNwfoNiaXM=; h=From:To:Cc:Subject:Date:From; b=Ua2kf3VZjIIkFbHCUgHFuh6yEuyDq5Lg1907l3oLg1B2S8kTEbM8GNOlOIsLFNru8 HdjWhP+w9zVzIBZ+9qkky5iZIkotwCgwlSBdtUBbC5HydTgN4D7mlAhGpFhQE01Pp1 OSl41PWKckZCFAY6zBd+K1hmuLU8d1VSM+Y5kg14= Received: by wens.tw (Postfix, from userid 1000) id 3B2A85FCD1; Sat, 11 Jul 2020 09:10:31 +0800 (CST) From: Chen-Yu Tsai To: Maxime Ripard , David Airlie , Daniel Vetter Cc: Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm: sun4i: hdmi: Fix inverted HPD result Date: Sat, 11 Jul 2020 09:10:30 +0800 Message-Id: <20200711011030.21997-1-wens@kernel.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chen-Yu Tsai When the extra HPD polling in sun4i_hdmi was removed, the result of HPD was accidentally inverted. Fix this by inverting the check. Fixes: bda8eaa6dee7 ("drm: sun4i: hdmi: Remove extra HPD polling") Signed-off-by: Chen-Yu Tsai --- Sorry for the screw-up. --- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c index 557cbe5ab35f..2f2c9f0a1071 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c @@ -260,7 +260,7 @@ sun4i_hdmi_connector_detect(struct drm_connector *connector, bool force) unsigned long reg; reg = readl(hdmi->base + SUN4I_HDMI_HPD_REG); - if (reg & SUN4I_HDMI_HPD_HIGH) { + if (!(reg & SUN4I_HDMI_HPD_HIGH)) { cec_phys_addr_invalidate(hdmi->cec_adap); return connector_status_disconnected; } -- 2.27.0