Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200711011459.1159929-1-shakeelb@google.com>
In-Reply-To: <20200711011459.1159929-1-shakeelb@google.com>
From:   Yafang Shao <laoar.shao@gmail.com>
Date:   Sat, 11 Jul 2020 09:54:28 +0800
Message-ID: <CALOAHbDWA2p_FhFHf227ie8djuY3ugkDsQq+v20BAUoJdXiH6Q@mail.gmail.com>
Subject: Re: [PATCH] mm: vmscan: consistent update to pgrefill
To:     Shakeel Butt <shakeelb@google.com>
Cc:     Johannes Weiner <hannes@cmpxchg.org>, Roman Gushchin <guro@fb.com>,
        Michal Hocko <mhocko@kernel.org>,
        Chris Down <chris@chrisdown.name>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Jul 11, 2020 at 9:15 AM Shakeel Butt <shakeelb@google.com> wrote:
>
> The vmstat pgrefill is useful together with pgscan and pgsteal stats to
> measure the reclaim efficiency. However vmstat's pgrefill is not updated
> consistently at system level. It gets updated for both global and memcg
> reclaim however pgscan and pgsteal are updated for only global reclaim.
> So, update pgrefill only for global reclaim. If someone is interested in
> the stats representing both system level as well as memcg level reclaim,
> then consult the root memcg's memory.stat instead of /proc/vmstat.
>
> Signed-off-by: Shakeel Butt <shakeelb@google.com>

Acked-by: Yafang Shao <laoar.shao@gmail.com>

> ---
>  mm/vmscan.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 5215840ee217..4167b0cc1784 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2030,7 +2030,8 @@ static void shrink_active_list(unsigned long nr_to_scan,
>
>         __mod_node_page_state(pgdat, NR_ISOLATED_ANON + file, nr_taken);
>
> -       __count_vm_events(PGREFILL, nr_scanned);
> +       if (!cgroup_reclaim(sc))
> +               __count_vm_events(PGREFILL, nr_scanned);
>         __count_memcg_events(lruvec_memcg(lruvec), PGREFILL, nr_scanned);
>
>         spin_unlock_irq(&pgdat->lru_lock);
> --
> 2.27.0.383.g050319c2ae-goog
>


-- 
Thanks
Yafang