Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1127175ybt; Sat, 11 Jul 2020 00:21:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjGCFAt1leDFjHIpL297hw5PlIDWVPgIAlpvlKcZcbyqPTurAbeS453glEy0UT75Bgt0cJ X-Received: by 2002:a17:906:edb3:: with SMTP id sa19mr63263994ejb.21.1594452069164; Sat, 11 Jul 2020 00:21:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594452069; cv=none; d=google.com; s=arc-20160816; b=KMGLRtPX3VAwTYz9UHANbQ626WPsYlyHbyyWaOtEhOkL/1LKiTdPfa5M6nVq4NXjmw cL1BxMI0xT9RfV0RiOjH9tq5jHMAGhKS3+/PwxeXdA6igLd2GhfeN2YhgijJmgr5pGdj mq2KI4EQsVXJXFFHQX240CdB75POSfOhnjpMgZt1RFMpq8Kew2l6SYnE/9QFBtUdNXq5 K793L34sL23sono6vZG56LnOMzx+hwx3GBput2LAAb9rXzX++W6UdQP4bwsNxi78riSH +jsgKH0TjAS1gwBZd5QCEoInSvmq9EBOJqzZA4vP5W63r13wrwqJ+ZxEttgDxXNOvi2O 0XPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=2sbW3VeapkXBFXBROMSYLe02+5wxSAmivcwGBlvvNys=; b=An30eUBFNM24gKj1NgjGF3RmJH6ZLufEo+mta/fAhltSWEyAATPRSSrbsB2WbZnj2C Rc4c2eI1Tw6iiAhbnsRmqbUqv3l4fdqrdQniAYYcaGCUCDVd3NTUMS0/flpeV2fMucIa G1l1jBEJMvXVu+qUZfCECI8TzeviYRi0tyrfvbhA5hjnOHradC63l8IEYtVVFwQbs3xy PXNa2s8d+2DVlgOTrRP8tE6Hrqo2ZbYFVQxzxSPVbl+YHVfAUtA7+FRfLXIrNNH1K6Vy JEbTR//y0hz+eNwqJQUVBfC/Quy04HPnb2SQ0b9Btn1VJv5lYQKEYmR/iDKp8ylPHiiQ /yBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QNzDaR01; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c3si5192606edr.308.2020.07.11.00.20.45; Sat, 11 Jul 2020 00:21:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QNzDaR01; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728049AbgGKHTf (ORCPT + 99 others); Sat, 11 Jul 2020 03:19:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726900AbgGKHTe (ORCPT ); Sat, 11 Jul 2020 03:19:34 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A40FBC08C5DD; Sat, 11 Jul 2020 00:19:34 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id z5so3530687pgb.6; Sat, 11 Jul 2020 00:19:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2sbW3VeapkXBFXBROMSYLe02+5wxSAmivcwGBlvvNys=; b=QNzDaR01054tkyz/YJVqi/q9TFcxmfse+9weq2nlchNL13op2HWRPqDMSWwCkroAn3 FD/DwkkfQAHAeqJIqKDP6/UnAjF7WpgYxNtjTPlMG38vmcMYd969ySf4saUQjpLc0hO+ sp0BrkYLT7k6zkgb2dRqS4tYp9sbXBYN9E+6kdfhVG2IGDlS43BQqtrQks/pkMEv6zxc jMPP/hyIpjezO3GEWX9EHBq8T/8Z9xxz1QAkVz61sEvYNZA+5hWjSFPV3BnYr+EJZ1Mg 7j7PPt1b1kPmPSzehKA54O3dv6hfd+RzHUqwa6rURaVkIpqitHJdxkTvbEadkrgKoIrs dwyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2sbW3VeapkXBFXBROMSYLe02+5wxSAmivcwGBlvvNys=; b=RVEnxRX1B9wPoGAH/7pmC9LYRgtpVxAqDZ2ZzEMZ9HW+Zfs+hUUpsh07IxcvOZV8r3 MsDJuzjjJFqkTrjlSrC+s66iQPjI6tfIWntQx8jymUjM8zrLwxpNWNh5jYZKAirzb/nW 0SiBPrZ03bPNb0wRtvo1NfArxLUzwR7+a/BkC/htnKWQMsJBg4j7slVlPCy/Z1PxZeRO ZDQ4zCDgWPqviYpa0bC4/AsGUzycyg7fbzAMe4AdV4fAWJ0O3CR9VENWaSiGbZNwJtIb MjSkYmrRy8hh/IcI7M/xgmAFimWFDwsf5fsnah1P9DA+iC3WE8lAqGjkUttZGcif9d+L ioiw== X-Gm-Message-State: AOAM533Qb28BmKet3BTTc7yS4zTIje/aMVj1d45gW6UjssFC1N774EXl pHWVpHkkxhZN07hoIvUEfGY= X-Received: by 2002:aa7:8513:: with SMTP id v19mr57199394pfn.74.1594451974086; Sat, 11 Jul 2020 00:19:34 -0700 (PDT) Received: from localhost ([89.208.244.139]) by smtp.gmail.com with ESMTPSA id f3sm7574725pju.54.2020.07.11.00.19.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 11 Jul 2020 00:19:33 -0700 (PDT) From: Dejin Zheng To: bhelgaas@google.com, lorenzo.pieralisi@arm.com, linux-pci@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Dejin Zheng Subject: [PATCH v1] PCI: Add more information when devm_request_mem_region() goes wrong Date: Sat, 11 Jul 2020 15:19:27 +0800 Message-Id: <20200711071927.3064-1-zhengdejin5@gmail.com> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add more information, the name of the resource will be printed when the request memory region or remapping of configuration space fails in the devm_request_mem_region() function. Signed-off-by: Dejin Zheng --- drivers/pci/pci.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index ce096272f52b..81c1045a3fa8 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -4153,13 +4153,15 @@ void __iomem *devm_pci_remap_cfg_resource(struct device *dev, name = res->name ?: dev_name(dev); if (!devm_request_mem_region(dev, res->start, size, name)) { - dev_err(dev, "can't request region for resource %pR\n", res); + dev_err(dev, "can't request region for %s's resource %pR\n", + name, res); return IOMEM_ERR_PTR(-EBUSY); } dest_ptr = devm_pci_remap_cfgspace(dev, res->start, size); if (!dest_ptr) { - dev_err(dev, "ioremap failed for resource %pR\n", res); + dev_err(dev, "ioremap failed for %s's resource %pR\n", + name, res); devm_release_mem_region(dev, res->start, size); dest_ptr = IOMEM_ERR_PTR(-ENOMEM); } -- 2.25.0