Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 11 Jul 2020 10:23:18 +0200
From:   Jesper Dangaard Brouer <brouer@redhat.com>
To:     Joe Perches <joe@perches.com>
Cc:     brouer@redhat.com,
        "Alexander A. Klimov" <grandmaster@al2klimov.de>, ast@kernel.org,
        daniel@iogearbox.net, davem@davemloft.net, kuba@kernel.org,
        hawk@kernel.org, john.fastabend@gmail.com,
        mchehab+huawei@kernel.org, robh@kernel.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        bpf@vger.kernel.org
Subject: Re: [PATCH v2] MAINTAINERS: XDP: restrict N: and K:
Message-ID: <20200711102318.28ce29d6@carbon>
In-Reply-To: <28a81dfe62b1dc00ccc721ddb88669d13665252b.camel@perches.com>
References: <87tuyfi4fm.fsf@toke.dk>
        <20200710190407.31269-1-grandmaster@al2klimov.de>
        <28a81dfe62b1dc00ccc721ddb88669d13665252b.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 10 Jul 2020 12:37:47 -0700
Joe Perches <joe@perches.com> wrote:

> On Fri, 2020-07-10 at 21:04 +0200, Alexander A. Klimov wrote:
> > Rationale:
> > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
> > which has nothing to do with XDP.
> >=20
> > Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
> > ---
> >  Better?
> >=20
> >  MAINTAINERS | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >=20
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 1d4aa7f942de..735e2475e926 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -18708,8 +18708,8 @@ F:	include/trace/events/xdp.h
> >  F:	kernel/bpf/cpumap.c
> >  F:	kernel/bpf/devmap.c
> >  F:	net/core/xdp.c
> > -N:	xdp
> > -K:	xdp
> > +N:	(?:\b|_)xdp
> > +K:	(?:\b|_)xdp =20
>=20
> Generally, it's better to have comprehensive files lists
> rather than adding name matching regexes.

I like below more direct matching of the files we already know are XDP
related. The pattern match are meant to catch drivers containing XDP
related bits.

(small typo in your patch below)

> Perhaps:
> ---
>  MAINTAINERS | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>=20
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 16854e47e8cb..2e96cbf15b31 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18763,13 +18763,19 @@ M:	John Fastabend <john.fastabend@gmail.com>
>  L:	netdev@vger.kernel.org
>  L:	bpf@vger.kernel.org
>  S:	Supported
> -F:	include/net/xdp.h
> +F:	Documentation/networking/af_xdp.rst
> +F:	include/net/xdp*
>  F:	include/trace/events/xdp.h
> +F:	include/uapi/linux/if_xdp.h
> +F:	include/uapi/linux/xdp_diag.h
>  F:	kernel/bpf/cpumap.c
>  F:	kernel/bpf/devmap.c
>  F:	net/core/xdp.c
> -N:	xdp
> -K:	xdp
> +F:	net/xdp/
> +F:	samples/bpf/xdp*
> +F:	tools/testing/selftests/bfp/*xdp*
                               ^^^^=20
Typo, should be "bpf"

> +F:	tools/testing/selftests/bfp/*/*xdp*
> +K:	(?:\b|_)xdp(?:\b|_)
> =20
>  XDP SOCKETS (AF_XDP)
>  M:	Bj=C3=B6rn T=C3=B6pel <bjorn.topel@intel.com>
>=20


--=20
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer