Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 11 Jul 2020 11:07:46 +0100
From:   Chris Down <chris@chrisdown.name>
To:     Shakeel Butt <shakeelb@google.com>
Cc:     Johannes Weiner <hannes@cmpxchg.org>, Roman Gushchin <guro@fb.com>,
        Michal Hocko <mhocko@kernel.org>,
        Yafang Shao <laoar.shao@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: vmscan: consistent update to pgrefill
Message-ID: <20200711100746.GA814207@chrisdown.name>
References: <20200711011459.1159929-1-shakeelb@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20200711011459.1159929-1-shakeelb@google.com>
User-Agent: Mutt/1.14.5 (2020-06-23)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Shakeel Butt writes:
>The vmstat pgrefill is useful together with pgscan and pgsteal stats to
>measure the reclaim efficiency. However vmstat's pgrefill is not updated
>consistently at system level. It gets updated for both global and memcg
>reclaim however pgscan and pgsteal are updated for only global reclaim.
>So, update pgrefill only for global reclaim. If someone is interested in
>the stats representing both system level as well as memcg level reclaim,
>then consult the root memcg's memory.stat instead of /proc/vmstat.
>
>Signed-off-by: Shakeel Butt <shakeelb@google.com>

Acked-by: Chris Down <chris@chrisdown.name>