Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1442568ybt;
        Sat, 11 Jul 2020 10:15:13 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyLjEcNd9GDOhjXkXTN/0wEyHRns/JxrjGig+7cCaAhKT3gks0vZMP2VFLb/fjK3Q7ZmR2i
X-Received: by 2002:a17:906:6446:: with SMTP id l6mr49113094ejn.184.1594487713017;
        Sat, 11 Jul 2020 10:15:13 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1594487713; cv=none;
        d=google.com; s=arc-20160816;
        b=ngISpta8P7jswKBYrdHGZ8SyrOt9lj9J3AYFb21gtPR/HFozgSbVSvzHj74KRtMkMu
         dfiPnlGWz/+oBsKJj++KZ+/ZJAWdN3nphh2ms/DLXCorcgIgDfHbrX2xpemPg0g7Y5XD
         CJPI8FpVwuE8cRkSB3WhO1BD2YFQylk9/AkgZ4kwIi+yS4LJ6AxXefgxkR8NuzLmerqT
         QvjUtlhjRCthpi1eN/sceCScQlKgyOutA5d14B6T2YjQ3l5e8WX7OzdesIicXrXMNxQq
         QftbaBpvhRJ5OTepIrPEqiHf2keXdeqSqFfp2delpN95e95OW3jPtX3syl38+ET2NfEk
         ezVg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:dkim-signature;
        bh=oz7fwNtidwXzlADsDXkWzd0peFPiys6/ovA6FQJ6Ux4=;
        b=kGSp5EM4Rj+za5XpfLwmvw8OPh+pGi4CVpEI+7QZANWSQbubQgA5ArPZrnMdoOystA
         iZdqThzMNf/mL3r1oG8gVuKSGdkQVQwLvNmcaj7Cwaav6EE3eceqRTtZiUCSjUwAAV6s
         s+EyOppejlsnMqEy2hcORkotqhjtyc3SQoU2d0lITm69qXnPZp0iZEYntWoY3nHLy0TG
         5JRNbvvlrRFAFspUjMoAW0Dwqa+zip1MnKxhq3E7JQoBQ/+8Ku5f+DnGim2NccU0jnvG
         /AB1B+FSyzV99o3uGWkE3XOFF2nMLw3CulOG2hx7BBQXY8//JzMWDtAi0PAjotBuiq4p
         5r/g==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b="WicGKo/y";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id t22si6628258edy.39.2020.07.11.10.14.50;
        Sat, 11 Jul 2020 10:15:13 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b="WicGKo/y";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728695AbgGKROF (ORCPT <rfc822;austinkernel.kim@gmail.com>
        + 99 others); Sat, 11 Jul 2020 13:14:05 -0400
Received: from mail.kernel.org ([198.145.29.99]:46292 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728674AbgGKROF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 11 Jul 2020 13:14:05 -0400
Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47])
        (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 96F492084C
        for <linux-kernel@vger.kernel.org>; Sat, 11 Jul 2020 17:14:04 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1594487644;
        bh=tFm00tYvn7vhjhKrCpNUrSPBZx/gcRTVNWRie6+SKEo=;
        h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
        b=WicGKo/yazUFc3Y5sF4bpw33UAMasXR8qJdo+xdl92gcFmf/d45lFAjoIjU++1tP+
         aGw+3o1AytpfprwyjLlL9IXJRnevuU054lx5VCKHOWpo0mYTcN15c5Kc8mpODIUZYN
         Gg9y4XeCycGs3oK3CINOj1BGxUyOMM67mmPd5pdc=
Received: by mail-wr1-f47.google.com with SMTP id f7so9010375wrw.1
        for <linux-kernel@vger.kernel.org>; Sat, 11 Jul 2020 10:14:04 -0700 (PDT)
X-Gm-Message-State: AOAM532UZ0fo19tt8EIVbpSZBj7jl+b+xMSbKgSNA6FJX+C+gf94hA3y
        ce3rSESP0luGTnMN1KEHvO7eKlbd2OIQHJPceZ1vRg==
X-Received: by 2002:adf:f888:: with SMTP id u8mr31368677wrp.18.1594487643227;
 Sat, 11 Jul 2020 10:14:03 -0700 (PDT)
MIME-Version: 1.0
References: <20200710224525.21966-1-bshanks@codeweavers.com>
In-Reply-To: <20200710224525.21966-1-bshanks@codeweavers.com>
From:   Andy Lutomirski <luto@kernel.org>
Date:   Sat, 11 Jul 2020 10:13:51 -0700
X-Gmail-Original-Message-ID: <CALCETrU8==gUPD7TygK_dVZZnzirpLUCWQCgYmEDn2s2Y5U_gg@mail.gmail.com>
Message-ID: <CALCETrU8==gUPD7TygK_dVZZnzirpLUCWQCgYmEDn2s2Y5U_gg@mail.gmail.com>
Subject: Re: [PATCH v5] x86/umip: Add emulation/spoofing for SLDT and STR instructions
To:     Brendan Shanks <bshanks@codeweavers.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, X86 ML <x86@kernel.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Andreas Rammhold <andi@notmuch.email>,
        "Moger, Babu" <Babu.Moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 10, 2020 at 3:45 PM Brendan Shanks <bshanks@codeweavers.com> wrote:
>
> Add emulation/spoofing of SLDT and STR for both 32- and 64-bit
> processes.
>
> Wine users have found a small number of Windows apps using SLDT that
> were crashing when run on UMIP-enabled systems.
>

Acked-by: Andy Lutomirski <luto@kernel.org>

I tested this under KVM-emulated UMIP.  I don't have a real UMIP
system handle to test STR.

--Andy