Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 11/11] media: exynos4-is: Correct parallel port probing
To:     Sylwester Nawrocki <s.nawrocki@samsung.com>,
        kyungmin.park@samsung.com, mchehab@kernel.org, kgene@kernel.org,
        krzk@kernel.org, linux-media@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20200426022650.10355-1-xc-racer2@live.ca>
 <CGME20200426022757eucas1p2d10b653b3d974a1226560ccceed0d120@eucas1p2.samsung.com>
 <BN6PR04MB0660A14860692EAB2A658AEFA3AE0@BN6PR04MB0660.namprd04.prod.outlook.com>
 <05381b4a-3581-e57d-3ecc-43eaafd9d527@samsung.com>
From:   Jonathan Bakker <xc-racer2@live.ca>
Message-ID: <BN6PR04MB0660D832F51C14CD10257B9EA3620@BN6PR04MB0660.namprd04.prod.outlook.com>
Date:   Sat, 11 Jul 2020 11:18:46 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
In-Reply-To: <05381b4a-3581-e57d-3ecc-43eaafd9d527@samsung.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2001:569:fb68:9c00:8067:f823:1e15:7520] (2001:569:fb68:9c00:8067:f823:1e15:7520) by MWHPR19CA0085.namprd19.prod.outlook.com (2603:10b6:320:1f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20 via Frontend Transport; Sat, 11 Jul 2020 18:18:48 +0000
X-Microsoft-Original-Message-ID: <c94c2b00-7dd0-9b05-7f3a-0032516b7d93@live.ca>
X-TMN:  [aeG9F7CT36SXSoG7+mQoj0Lk4fmE18ZZudW9Qc953ZMvoAK4HxdOCtbCKG8VgpH8]
X-MS-PublicTrafficType: Email
X-IncomingHeaderCount: 48
X-EOPAttributedMessage: 0
X-MS-Office365-Filtering-Correlation-Id: 8589d836-1a41-40e5-e3e9-08d825c6dc2e
X-MS-TrafficTypeDiagnostic: DM6NAM11HT016:
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Qp3N6CTTtQdBMKXy6DdldoRYfNX4qXuNAtD5P9nUOS6DUjqG05PZ6Wq1dhHP11g9+7H+INxKRk2gcX8JTNcq1sIy185lSf3MquyQAnoJTWcWCBXcz5jsNL/FHyjTFyYlvldPgvzYJCQC+NENcA0/j+9x67NzHdz7EysjyoGdb36ITTmN6oPPutFViKzR8/ViteGvESNDuY1T+GPkar1e4w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR04MB0660.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901;
X-MS-Exchange-AntiSpam-MessageData: 72Z21YTWq7QgusVeMQMm8GJFR6qzo3K/w1Hv+5ITy3iu6YAcDDw/UKkNSPARRMAfvA5WcmmK7iTj5NnnOl/tB0Yd/O2SKr3sT3D3AnzDjjDAJYw4IM7Zwyd7jeaxi/cofGYGEXb2PuEZm1WCoUoQAhbeOu2WUtZHSYReiDzq4k5mHjfuUns+midf50sKFpHw7/DFluMPDY9gBHUVvC3liw==
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8589d836-1a41-40e5-e3e9-08d825c6dc2e
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2020 18:18:50.4256
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT041.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: Internet
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM11HT016
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sylwester,

On 2020-07-08 9:15 a.m., Sylwester Nawrocki wrote:
> Hi,
> 
> On 26.04.2020 04:26, Jonathan Bakker wrote:
>> According to the binding doc[1], port A should be reg = 0
>> and port B reg = 1.  Unfortunately, the driver was treating 0
>> as invalid and 1 as camera port A.  Match the binding doc and
>> make 0=A and 1=B.
>>
>> [1] Documentation/devicetree/bindings/media/samsung-fimc.txt
> 
> Thank you for correcting this. I would prefer to correct the binding
> documentation instead, so it says reg=1 for A and reg=2 for B. 
> Then it would also match what we have in dts for Goni and 
> enum fimc_input in include/media/drv-intf/exynos-fimc.h

No problem, that works for me.  I'll drop this patch and replace it with one
changing the documentation.

> 
> 

Thanks,
Jonathan