Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] MIPS: CI20: DTS: Correcting IW8103 Wifi binding
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Content-Type: text/plain; charset=utf-8
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <f617580b-fad7-f4f2-e89d-402b53c21c47@deutnet.info>
Date:   Sat, 11 Jul 2020 22:24:47 +0200
Cc:     Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Ralf Baechle <ralf@linux-mips.org>,
        Paul Burton <paul.burton@mips.com>,
        James Hogan <jhogan@kernel.org>,
        linux-mips <linux-mips@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <6AB9C165-7B42-44A6-BCA8-8879B7D70699@goldelico.com>
References: <20200705103215.96672-1-agriveaux@deutnet.info> <457C75ED-A033-4B46-A9D9-53B510C16F37@goldelico.com> <f617580b-fad7-f4f2-e89d-402b53c21c47@deutnet.info>
To:     Alexandre GRIVEAUX <agriveaux@deutnet.info>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Alexandre,

> Am 06.07.2020 um 22:22 schrieb Alexandre GRIVEAUX =
<agriveaux@deutnet.info>:
>=20
> Le 06/07/2020 =C3=A0 13:15, H. Nikolaus Schaller a =C3=A9crit :
>> Hi Alexandre,
>>=20
>>> Am 05.07.2020 um 12:32 schrieb agriveaux@deutnet.info:
>>>=20
>>> From: Alexandre GRIVEAUX <agriveaux@deutnet.info>
>>>=20
>>> Use brcm,bcm4329-fmac instead of brcm,bcm4330-fmac.
>>>=20
>>> Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info>
>>> ---
>>> arch/mips/boot/dts/ingenic/ci20.dts | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>=20
>>> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts =
b/arch/mips/boot/dts/ingenic/ci20.dts
>>> index 75f5bfbf2c37..82a1f126b778 100644
>>> --- a/arch/mips/boot/dts/ingenic/ci20.dts
>>> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
>>> @@ -116,8 +116,8 @@
>>> 	pinctrl-0 =3D <&pins_mmc1>;
>>>=20
>>> 	brcmf: wifi@1 {
>>> -/*		reg =3D <4>;*/
>>> -		compatible =3D "brcm,bcm4330-fmac";
>>> +		reg =3D <1>;
>>> +		compatible =3D "brcm,bcm4329-fmac";
>>> 		vcc-supply =3D <&wlan0_power>;
>>> 		device-wakeup-gpios =3D <&gpd 9 GPIO_ACTIVE_HIGH>;
>>> 		shutdown-gpios =3D <&gpf 7 GPIO_ACTIVE_LOW>;
>> Do you have it working with a v5.8 kernel?
>>=20
>> I don't see any activity to detect the module or load firmware.
>>=20
>> Does it rely on some other patch?
>>=20
>> BR and thanks,
>> Nikolaus
>>=20
> Hi Nikolaus
>=20
>=20
> At this time the patch have been only "tested" for error will doing =
make:
>=20
> make ARCH=3Dmips CROSS_COMPILE=3Dmipsel-linux-gnu- olddefconfig &&  =
make
> ARCH=3Dmips CROSS_COMPILE=3Dmipsel-linux-gnu- -j8 && make ARCH=3Dmips
> CROSS_COMPILE=3Dmipsel-linux-gnu- -j8 uImage
>=20
>=20
> The .config come from creator-ci20 kernel 'config-3.18.3-ci20-1'
>=20
>=20
> Even with the right DT
> (Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt)
> it's need some config with brcm enabled I gess.
>=20
>=20
> I need to do some investigation will trying the uImage this week,
> unfortunaly kernel developpement is not my main work, it's a hobby.

No problem. For me, the CI20 is also a hobby project :)

Here is some information about the CI20 WiFi and firmware:

https://elinux.org/CI20_Hardware#WiFi.2FBT

https://elinux.org/CI20_upstream#WiFi_firmware

So to be it looks as if the

compatible =3D "brcm,bcm4330-fmac";

is correct. But the reg =3D <4> or <1> is something we have to find out.

BR,
Nikolaus