Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1554990ybt; Sat, 11 Jul 2020 14:19:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw51SnOFX4+thcIIVZRZhO3cEoIGIKWjmTScydMTVfifJU7OUNSPJDSb5c3ukXEugoMIk24 X-Received: by 2002:a50:ee8d:: with SMTP id f13mr80919892edr.302.1594502359024; Sat, 11 Jul 2020 14:19:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594502359; cv=none; d=google.com; s=arc-20160816; b=lO2mVbRYtKQya2asPvUuHcIPk137DpFerCc57SPkg0qOSOZ7OhfK1LzCnzmuB4PkHe T8F198Xplmy2XQzQ5fw00EoPM1zL7Jfr9gMqsxlYRFgmk32pXjhQT9Qomb2uIMQ/hOwF W6Ob4i4cUbUq+W2/YynQgm3Y82Ap6/ny2a2KmXLZNfBT8QtJ+7vq8fmwJoFWlKYbpsOn HZ7K9hRj+D65kKJYJpNjDjmGsbRHDycvESIVQk3GxzrtU3RSX1n9Yd206JLUNyYgI5Nq xnPlRX5r6LaC7m4iZDgcab75cG1J1uITwewEG+5FXrQVi+gs6LtrX/z3q6XpO9cjG2eb jgYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=wqb18s+NYtJBD4ijNg7d8R2/EPoJeQ86xG7wEDLp5I0=; b=kLH0kTDlGnVq2z9RlxYUj9aG5XRWybOYoe5GpVVdLGPBgQGFOQdfDipOgYQDilPD5Q hh4SaFoByr2lhWHpic4vHwtt27RmBPSZa9Q2kG/nR8LB4pMJFtiX//7vxdmARfxcB+pj BjqQ3dphEPObry4V7RykdQLMnbxaICaSW6W6vqWIP61CcXXCezVoVNY27JEWP1oS0zLt Hb2iMb1eW10BojEocpc8YzuS3NNE9LFU6MMe4Ev2d8padSJNKmM28MtxKFFEVaiI8orm KVUhXV0Hf+yLAzNm+utADaU58JNjo+PMxyGngqHxDnUYqYI9kJEVadpJfSyZpKidiZ70 chXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UqNakKmZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f15si7111641edt.552.2020.07.11.14.18.56; Sat, 11 Jul 2020 14:19:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UqNakKmZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727777AbgGKVR5 (ORCPT + 99 others); Sat, 11 Jul 2020 17:17:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726779AbgGKVR5 (ORCPT ); Sat, 11 Jul 2020 17:17:57 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECB68C08C5DE for ; Sat, 11 Jul 2020 14:17:56 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id q7so10422821ljm.1 for ; Sat, 11 Jul 2020 14:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wqb18s+NYtJBD4ijNg7d8R2/EPoJeQ86xG7wEDLp5I0=; b=UqNakKmZZ125zE7aCrUB/FRrke2hYX8bYIK72Azll6JhZ9g46WilSX2lPkVONVzkUn 38oy1jIZbRqpBJqkOD51aYCJmb4Q4ElI2SAzJzDx2C0I0q7XCi1+zbT/MjHXnpnjHz+B lGug/VLskaWGmyA3bbZaudgCg2sieCTvxiamZDlgPXJDizun+WoNnsonxdYKxE4AT229 FcWc98rUvcWF3JXBq/Gwr55pydfM5BitCAzvjIymtpl+dfRDYQtrsmnHsEKEM1/bein5 iuAgSGLetrR08XSBvlJGEFzCLZo4AwNPGS2Wh3mZEJP/crq5RsZ3dA1A75XozhvnO5ES yJrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wqb18s+NYtJBD4ijNg7d8R2/EPoJeQ86xG7wEDLp5I0=; b=UvnrTITIoBex34m2BOHDwTg97D+oDLtNiVa79UmHhtXg/m3jEfajPtiMfzQ8F3Fxdp 2YeXuxsuFVqp6KDweaPEGPi+mtv3HtAEPd7qioxrqoJnhJuHgaUq7GEf6ET0mlfIHgQW Mr9/QMEJPI9s64djA04vwqgcQNhHTQHSlvufVDJBxYg7XiAWMitr+zIcLu2ihFvoCpj5 nKUlR4ltwJ5cDJUaLia6FfWeKyOQrBSolonVFswhbPf1skeOjJ67K1qgwO7VnlpbdlpU 0gPIsF9jbuSMdK7fThJZZHCCGukMDk5A35j6YYI2BRVZtwrXZtTrwvLjEemOUyEdPlpD 7TYw== X-Gm-Message-State: AOAM5321oX6/g8EpzW/75UyhcZz8YR+IeuED/gBJsRId1yolIcOb1OFa EZ2HNB19jNJ2skIUe57dJvYYJg+MYrwzjtuMqTtiFw== X-Received: by 2002:a2e:8597:: with SMTP id b23mr27400495lji.338.1594502275360; Sat, 11 Jul 2020 14:17:55 -0700 (PDT) MIME-Version: 1.0 References: <1594164323-14920-1-git-send-email-Anson.Huang@nxp.com> In-Reply-To: <1594164323-14920-1-git-send-email-Anson.Huang@nxp.com> From: Linus Walleij Date: Sat, 11 Jul 2020 23:17:44 +0200 Message-ID: Subject: Re: [PATCH 1/3] gpio: mxc: Support module build To: Anson Huang Cc: Russell King , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , Catalin Marinas , Will Deacon , Bartosz Golaszewski , oleksandr.suvorov@toradex.com, Adam Ford , Andreas Kemnade , hverkuil-cisco@xs4all.nl, Bjorn Andersson , Leo Li , Vinod Koul , Geert Uytterhoeven , Olof Johansson , Linux ARM , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , NXP Linux Team Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 8, 2020 at 1:28 AM Anson Huang wrote: > subsys_initcall(gpio_mxc_init); > + > +MODULE_AUTHOR("Shawn Guo "); > +MODULE_DESCRIPTION("i.MX GPIO Driver"); > +MODULE_LICENSE("GPL"); You are making this modualrizable but keeping the subsys_initcall(), which doesn't make very much sense. It is obviously not necessary to do this probe at subsys_initcall() time, right? Take this opportunity to convert the driver to use module_platform_driver() as well. Yours, Linus Walleij