Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp288352ybh; Sun, 12 Jul 2020 06:29:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgCLKSKHHInWhe/cwrIVRzL3YMgvYAEZQRvqGSCEqwtIAS279wPJOnGzKukdwXVI6rnv5k X-Received: by 2002:a17:906:7e04:: with SMTP id e4mr62781369ejr.83.1594560572070; Sun, 12 Jul 2020 06:29:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594560572; cv=none; d=google.com; s=arc-20160816; b=sCnBDkHQ9JK7bbjLMpXVqpwfVrIBGSZDfPzXN0R00jsGS373ZpMgZLs5e6swMA3TT5 p+Y9u9PTQcj5KcpWqZkRdAwkfzVeqzajkKsnX+E2DIob//bcBEUcxN8M8fV0RI5HUhDR VTx9vhVHbU4QppXhL5v/fExzDINme6E0Z72nNsf/vBPbgs6WdNbS68aBQCFTygI+5jya PntPZsL3fYLo0d/9dOCh+Uoi30RmcyT0c4cx4riP6kV3FywTOTgTB0txppUeQa29wa1+ c6JhPyiIT9P03TSQH8ujR5Q7yPzpll8KPTLY/09b/sAVQyAcOnzkrkD50rQmUPVBbvox bqPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=o5HATjvEErcJq2bJgYN3DYkoQer0tBo2Nox1EGmyIrY=; b=ilzWQGboetO0m5MXhOpNIOGZPV+oFpvZsfO6Q5O8vFidlJ7tuKjkH4ceHO4gHCepo6 lmSOjmWFtiomuhZyoeCQmWnBh9+b8yr2mXhWpgGUoRmBP1vjqj1+xZmfP2zp+LIuHWwV BWXZ5aC/n+358a7h/N2YOc8ItT+smxBwTSI9Uk7Yz083ryGjRGbmTfSRT7/HBJBLXjov 1sdfit623kImFwRK2RPoLU4HfgEixPyVwg+N8pTpMo6TkJEGGUfPejdoFt1Tg9O/SYkI W1XFzCWNaQnxbmzkutFQh2zmai0K6KsIGDFEzcylfe1Gi+vHf8p0Kq0fiJEfNQWZm6rq xNpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h8si9600546edn.92.2020.07.12.06.29.09; Sun, 12 Jul 2020 06:29:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729031AbgGLN1d convert rfc822-to-8bit (ORCPT + 99 others); Sun, 12 Jul 2020 09:27:33 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:20693 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729024AbgGLN1b (ORCPT ); Sun, 12 Jul 2020 09:27:31 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-155-GPdU_L7BOYmIuunEnC2YHw-1; Sun, 12 Jul 2020 09:27:26 -0400 X-MC-Unique: GPdU_L7BOYmIuunEnC2YHw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E3F471081; Sun, 12 Jul 2020 13:27:24 +0000 (UTC) Received: from krava.redhat.com (unknown [10.40.192.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1BEEB1944D; Sun, 12 Jul 2020 13:27:21 +0000 (UTC) From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Michael Petlan , Andi Kleen , Kajol Jain , John Garry , "Paul A. Clarke" , Stephane Eranian , Ian Rogers Subject: [PATCH 14/18] perf metric: Add cache_miss_cycles to metric parse test Date: Sun, 12 Jul 2020 15:26:30 +0200 Message-Id: <20200712132634.138901-15-jolsa@kernel.org> In-Reply-To: <20200712132634.138901-1-jolsa@kernel.org> References: <20200712132634.138901-1-jolsa@kernel.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kernel.org Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adding test that compute metric with other metrics in it. cache_miss_cycles = metric:dcache_miss_cpi + metric:icache_miss_cycles Signed-off-by: Jiri Olsa --- tools/perf/tests/parse-metric.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/tools/perf/tests/parse-metric.c b/tools/perf/tests/parse-metric.c index 8c48251425e1..28f33893338b 100644 --- a/tools/perf/tests/parse-metric.c +++ b/tools/perf/tests/parse-metric.c @@ -11,6 +11,8 @@ #include "debug.h" #include "expr.h" #include "stat.h" +#include +#include static struct pmu_event pme_test[] = { { @@ -22,6 +24,18 @@ static struct pmu_event pme_test[] = { "( 1 + cpu_clk_unhalted.one_thread_active / cpu_clk_unhalted.ref_xclk ) )))", .metric_name = "Frontend_Bound_SMT", }, +{ + .metric_expr = "l1d\\-loads\\-misses / inst_retired.any", + .metric_name = "dcache_miss_cpi", +}, +{ + .metric_expr = "l1i\\-loads\\-misses / inst_retired.any", + .metric_name = "icache_miss_cycles", +}, +{ + .metric_expr = "(dcache_miss_cpi + icache_miss_cycles)", + .metric_name = "cache_miss_cycles", +}, }; static struct pmu_events_map map = { @@ -162,9 +176,28 @@ static int test_frontend(void) return 0; } +static int test_cache_miss_cycles(void) +{ + double ratio; + struct value vals[] = { + { .event = "l1d-loads-misses", .val = 300 }, + { .event = "l1i-loads-misses", .val = 200 }, + { .event = "inst_retired.any", .val = 400 }, + { 0 }, + }; + + TEST_ASSERT_VAL("failed to compute metric", + compute_metric("cache_miss_cycles", vals, &ratio) == 0); + + TEST_ASSERT_VAL("cache_miss_cycles failed, wrong ratio", + ratio == 1.25); + return 0; +} + int test__parse_metric(struct test *test __maybe_unused, int subtest __maybe_unused) { TEST_ASSERT_VAL("IPC failed", test_ipc() == 0); TEST_ASSERT_VAL("frontend failed", test_frontend() == 0); + TEST_ASSERT_VAL("cache_miss_cycles failed", test_cache_miss_cycles() == 0); return 0; } -- 2.25.4