Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] decompress_bunzip2: fix sizeof type in start_bunzip
To:     "H. Peter Anvin" <hpa@zytor.com>, alain@knaff.lu
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org
References: <20200712125952.8809-1-trix@redhat.com>
 <639c8ef5-2755-7172-fbb8-ce45c8637feb@zytor.com>
From:   Tom Rix <trix@redhat.com>
Message-ID: <9af191c2-0f2c-7637-433a-b557a07590ca@redhat.com>
Date:   Sun, 12 Jul 2020 08:12:43 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <639c8ef5-2755-7172-fbb8-ce45c8637feb@zytor.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 7/12/20 6:09 AM, H. Peter Anvin wrote:
> On 2020-07-12 05:59, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> clang static analysis flags this error
>>
>> lib/decompress_bunzip2.c:671:13: warning: Result of 'malloc' is converted
>>   to a pointer of type 'unsigned int', which is incompatible with sizeof
>>   operand type 'int' [unix.MallocSizeof]
>>         bd->dbuf = large_malloc(bd->dbufSize * sizeof(int));
>>                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Reviewing the bunzip_data structure, the element dbuf is type
>>
>> 	/* Intermediate buffer and its size (in bytes) */
>> 	unsigned int *dbuf, dbufSize;
>>
>> So change the type in sizeof to 'unsigned int'
>>
> You must be kidding.
>
> If you want to change it, change it to sizeof(bd->dbuf) instead, but this flag
> is at least in my opinion a total joke. For sizeof(int) != sizeof(unsigned
> int) is beyond bizarre, no matter how stupid the platform.

Using the actual type is more correct that using a type of the same size.

trix

> 	-hpa
>