Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <27660a3e38af43c9e741a4dfcdec50757c32f409.camel@perches.com>
Subject: Re: [PATCH] decompress_bunzip2: fix sizeof type in start_bunzip
From:   Joe Perches <joe@perches.com>
To:     Tom Rix <trix@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        alain@knaff.lu
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org
Date:   Sun, 12 Jul 2020 14:49:44 -0700
In-Reply-To: <9af191c2-0f2c-7637-433a-b557a07590ca@redhat.com>
References: <20200712125952.8809-1-trix@redhat.com>
         <639c8ef5-2755-7172-fbb8-ce45c8637feb@zytor.com>
         <9af191c2-0f2c-7637-433a-b557a07590ca@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.36.3-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 2020-07-12 at 08:12 -0700, Tom Rix wrote:
> On 7/12/20 6:09 AM, H. Peter Anvin wrote:
> > On 2020-07-12 05:59, trix@redhat.com wrote:
> > > From: Tom Rix <trix@redhat.com>
[]
> > > So change the type in sizeof to 'unsigned int'
> > You must be kidding.
> > 
> > If you want to change it, change it to sizeof(bd->dbuf) instead, but this flag
> > is at least in my opinion a total joke. For sizeof(int) != sizeof(unsigned
> > int) is beyond bizarre, no matter how stupid the platform.
> 
> Using the actual type is more correct that using a type of the same size.

Sure.

But this hardly matters as this same type conversion
from signed to unsigned or the other way round is
_everywhere_ in the kernel.

And especially the cc of stable is unnecessary.