Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 13 Jul 2020 01:15:44 +0200
From:   Marek Behun <marek.behun@nic.cz>
To:     =?UTF-8?B?T25kxZllag==?= Jirman <megous@megous.com>
Cc:     Pavel Machek <pavel@ucw.cz>, linux-kernel@vger.kernel.org,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Dan Murphy <dmurphy@ti.com>,
        "open list:LED SUBSYSTEM" <linux-leds@vger.kernel.org>
Subject: Re: [PATCH RFC] leds: Add support for per-LED device triggers
Message-ID: <20200713011544.0adc51f1@nic.cz>
In-Reply-To: <20200712223821.742ljr4qxdrx3aqv@core.my.home>
References: <20200702144712.1994685-1-megous@megous.com>
        <20200711100409.GA18901@amd>
        <20200711210111.5ysijhexgyzyr7u7@core.my.home>
        <20200712072554.GC4721@duo.ucw.cz>
        <20200712134911.r3lig4hgyqhmslth@core.my.home>
        <20200712191111.GA20592@amd>
        <20200712223821.742ljr4qxdrx3aqv@core.my.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 13 Jul 2020 00:38:21 +0200
Ond=C5=99ej Jirman <megous@megous.com> wrote:

> Hello,
>=20
> On Sun, Jul 12, 2020 at 09:11:11PM +0200, Pavel Machek wrote:
> > Hi!
> >  =20
>=20
> [....]
>=20
> >  		}
> > diff --git a/include/linux/leds.h b/include/linux/leds.h
> > index 2451962d1ec5..cba52714558f 100644
> > --- a/include/linux/leds.h
> > +++ b/include/linux/leds.h
> > @@ -57,6 +57,10 @@ struct led_init_data {
> >  	bool devname_mandatory;
> >  };
> > =20
> > +struct led_hw_trigger_type {
> > +	int dummy;
> > +}
> > +
> >  struct led_classdev {
> >  	const char		*name;
> >  	enum led_brightness	 brightness;
> > @@ -150,6 +154,8 @@ struct led_classdev {
> > =20
> >  	/* Ensures consistent access to the LED Flash Class device */
> >  	struct mutex		led_access;
> > +
> > +	struct led_hw_trigger_type *trigger_type;
> >  };
> > =20
> >  /**
> > @@ -345,6 +351,9 @@ struct led_trigger {
> >  	int		(*activate)(struct led_classdev *led_cdev);
> >  	void		(*deactivate)(struct led_classdev *led_cdev);
> > =20
> > +	/* LED-private triggers have this set. */
> > +	struct led_hw_trigger_type *trigger_type;
> > +
> >  	/* LEDs under control by this trigger (for simple triggers) */
> >  	rwlock_t	  leddev_list_lock;
> >  	struct list_head  led_cdevs; =20
>=20
> So after trying to use this, this seems to disallow the use of multiple HW
> triggers per LED. That's fine by me, because using one HW sysfs configured
> trigger per LED that use case is my proposal, but is it desireable in gen=
eral?

Why? If you register one LED and several triggers, all sharing the same
trigger_type pointer, I think it should work.

Marek