Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: fSTj7bQRcEsB1XtstARi7P2B3kqSy4Cgy1UudQq4NUtd2Coiv/Q5lEc9ArK1pJ8Fgrwi2IZXUJ
 MZgujUHND89w==
IronPort-SDR: Zs6lenS7Wgpo3n8w5Vp2sagKfsqwSr7MBh4M5MGPbpuwx84FK+KuMJAKbgXVDysn5amjPIxRj7
 cfW9QpGNYa4A==
Date:   Mon, 13 Jul 2020 09:52:24 +0800
From:   Xu Yilun <yilun.xu@intel.com>
To:     Moritz Fischer <mdf@kernel.org>
Cc:     "Wu, Hao" <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "lgoncalv@redhat.com" <lgoncalv@redhat.com>,
        Matthew Gerlach <matthew.gerlach@linux.intel.com>,
        "Weight, Russell H" <russell.h.weight@intel.com>,
        yilun.xu@intel.com
Subject: Re: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
Message-ID: <20200713015224.GA2624@yilunxu-OptiPlex-7050>
References: <1594282705-32289-1-git-send-email-yilun.xu@intel.com>
 <DM6PR11MB3819117029F124067F7EA8B985640@DM6PR11MB3819.namprd11.prod.outlook.com>
 <20200709093527.GA32541@yilunxu-OptiPlex-7050>
 <DM6PR11MB3819D07348C347B5BB8F86C085640@DM6PR11MB3819.namprd11.prod.outlook.com>
 <2d7919d5-a320-58f4-5c9d-7ef868ad8676@redhat.com>
 <20200710052443.GB8689@yilunxu-OptiPlex-7050>
 <DM6PR11MB3819BF1B54D64AD706BF832E85650@DM6PR11MB3819.namprd11.prod.outlook.com>
 <20200710154616.GA130068@epycbox.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200710154616.GA130068@epycbox.lan>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jul 10, 2020 at 08:46:16AM -0700, Moritz Fischer wrote:
> On Fri, Jul 10, 2020 at 06:14:19AM +0000, Wu, Hao wrote:
> > > On Thu, Jul 09, 2020 at 06:00:40AM -0700, Tom Rix wrote:
> > > >
> > > > On 7/9/20 3:14 AM, Wu, Hao wrote:
> > > > >> On Thu, Jul 09, 2020 at 05:10:49PM +0800, Wu, Hao wrote:
> > > > >>>> Subject: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
> > > > >>>>
> > > > >>>> Add PCIe Device ID for Intel FPGA PAC N3000.
> > > > >>>>
> > > > >>>> Signed-off-by: Wu Hao <hao.wu@intel.com>
> > > > >>>> Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> > > > >>>> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > > >>>> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> > > > >>>> ---
> > > > >>>>  drivers/fpga/dfl-pci.c | 2 ++
> > > > >>>>  1 file changed, 2 insertions(+)
> > > > >>>>
> > > > >>>> diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
> > > > >>>> index 73b5153..824aecf 100644
> > > > >>>> --- a/drivers/fpga/dfl-pci.c
> > > > >>>> +++ b/drivers/fpga/dfl-pci.c
> > > > >>>> @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev
> > > *pcidev)
> > > > >>>>  #define PCIE_DEVICE_ID_PF_INT_5_X0xBCBD
> > > > >>>>  #define PCIE_DEVICE_ID_PF_INT_6_X0xBCC0
> > > > >>>>  #define PCIE_DEVICE_ID_PF_DSC_1_X0x09C4
> > > > >>>> +#define PCIE_DEVICE_ID_PF_PAC_N3000 0x0B30
> > > > >>> Should we drop _PF_ here? and also do you want _INTEL_ here?
> > > > >> I think we could keep _PF_, also there is no need to support VF of pac
> > > > >> n3000 in product now, but it does exist (ID: 0x0b31).
> > > >
> > > > I was wondering about the vf id, thanks!
> > > >
> > > > >>
> > > > >> And add _INTEL_ is good to me.
> > > > >>
> > > > >> Then how about this one:
> > > > >>   #define PCIE_DEVICE_ID_PF_INTEL_PAC_N3000	0x0B30
> > > > > I am just considering the alignment with ids defined in
> > > include/linux/pci_ids.h
> > > > > So drop _PF_ before _INTEL_ would be better? : )
> > > >
> > > > To be consistent, all the id's are intel and all could drop pf.
> > > 
> > > That's good to me after checking the pci_ids.h. So we have:
> > > 
> > > #define PCIE_DEVICE_ID_INTEL_PAC_N3000        0x0B30
> > 
> > Sounds good to me.
> > 
> > Hao
> 
> Heads up I was gonna send out the PR early next week. I can fix this up
> myself if you want if you want or you can resend it?

I sent the v2 patch for this. Please help check it.

Thanks,
Yilun

> 
> Thanks,
> Moritz