Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Philippe Schenker <philippe.schenker@toradex.com>
CC:     Rob Herring <robh+dt@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Fabio Estevam <festevam@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] usb: chipidea: imx: support disabling runtime-pm
Thread-Topic: [PATCH 2/3] usb: chipidea: imx: support disabling runtime-pm
Thread-Index: AQHWVtG+IVcgco4rmU66cFLuq3QOdakE0tqA
Date:   Mon, 13 Jul 2020 02:49:31 +0000
Message-ID: <20200713024937.GA2388@b29397-desktop>
References: <20200710154935.697190-1-philippe.schenker@toradex.com>
 <20200710154935.697190-2-philippe.schenker@toradex.com>
In-Reply-To: <20200710154935.697190-2-philippe.schenker@toradex.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2F244EAEAC2F4B48B3364DE58809684A@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 348dd771-5046-45a5-67d9-08d826d75ea2
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2020 02:49:31.9853
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HrKhynSjcwM54KBc8XHzdzuGbGGaBBxqM7NNWJPpdft/H4taLkaLlotXFEKVFMkmqil9tMidrIOThmHTFFPS7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3026
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-07-10 17:49:33, Philippe Schenker wrote:
> Chipidea depends on some hardware signals to be there in order
> for runtime-pm to work well. Add the possibility to disable runtime
> power management that is necessary for certain boards.
>=20
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> ---
>=20
>  drivers/usb/chipidea/ci_hdrc_imx.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci=
_hdrc_imx.c
> index 5ae16368a0c7..5078d0695eb7 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -434,6 +434,9 @@ static int ci_hdrc_imx_probe(struct platform_device *=
pdev)
>  		usb_phy_init(pdata.usb_phy);
>  	}
> =20
> +	if (of_property_read_bool(np, "disable-runtime-pm"))
> +		pdata.flags &=3D ~CI_HDRC_SUPPORTS_RUNTIME_PM;
> +
>  	if (pdata.flags & CI_HDRC_SUPPORTS_RUNTIME_PM)
>  		data->supports_runtime_pm =3D true;
> =20

The changes are OK, you may add some descriptions like Fabio suggested,
eg, your use cases.

--=20

Thanks,
Peter Chen=