Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <4af50c95-36f6-7a61-5a22-2949970fe7a5@linux.intel.com> <93e1c3b1-ee77-a94d-8806-049e0245fab7@linux.intel.com>
In-Reply-To: <93e1c3b1-ee77-a94d-8806-049e0245fab7@linux.intel.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Mon, 13 Jul 2020 12:20:59 +0900
Message-ID: <CAM9d7cikDcaLaUv8+xh9fp_KVHFVQD+eRYGAR5kN4A7ppPHmBQ@mail.gmail.com>
Subject: Re: [PATCH v10 05/15] perf evlist: implement control command handling functions
To:     Alexey Budankov <alexey.budankov@linux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jul 8, 2020 at 4:50 PM Alexey Budankov
<alexey.budankov@linux.intel.com> wrote:
>
>
> Implement functions of initialization, finalization and processing
> of control command messages coming from control file descriptors.
> Allocate control file descriptor as descriptor at struct pollfd
> object of evsel_list for atomic poll() operation.
>
> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
> ---
[SNIP]
> +static int evlist__ctlfd_recv(struct evlist *evlist, enum evlist_ctl_cmd *cmd,
> +                             char *cmd_data, size_t data_size)
> +{
> +       int err;
> +       char c;
> +       size_t bytes_read = 0;
> +
> +       memset(cmd_data, 0, data_size--);

I overlooked the '--' at the end and thought there might be
buffer overflow..  Care to add a comment?

> +
> +       do {
> +               err = read(evlist->ctl_fd.fd, &c, 1);

Maybe I missed earlier discussion, but do we really want
this 1 byte read in a loop?

Thanks
Namhyung


> +               if (err > 0) {
> +                       if (c == '\n' || c == '\0')
> +                               break;
> +                       cmd_data[bytes_read++] = c;
> +                       if (bytes_read == data_size)
> +                               break;
> +               } else {
> +                       if (err == -1)
> +                               pr_err("Failed to read from ctlfd %d: %m\n", evlist->ctl_fd.fd);
> +                       break;
> +               }
> +       } while (1);
> +
> +       pr_debug("Message from ctl_fd: \"%s%s\"\n", cmd_data,
> +                bytes_read == data_size ? "" : c == '\n' ? "\\n" : "\\0");
> +
> +       if (err > 0) {
> +               if (!strncmp(cmd_data, EVLIST_CTL_CMD_ENABLE_TAG,
> +                            (sizeof(EVLIST_CTL_CMD_ENABLE_TAG)-1))) {
> +                       *cmd = EVLIST_CTL_CMD_ENABLE;
> +               } else if (!strncmp(cmd_data, EVLIST_CTL_CMD_DISABLE_TAG,
> +                                   (sizeof(EVLIST_CTL_CMD_DISABLE_TAG)-1))) {
> +                       *cmd = EVLIST_CTL_CMD_DISABLE;
> +               }
> +       }
> +
> +       return err;
> +}