Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp680908ybh; Sun, 12 Jul 2020 20:27:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlI+RlHJbvsnc7qEUqUBPL7vHyisxNEVP79cFTbVW3kjgYOiMugI0dWgELNm4BZw0JMHFX X-Received: by 2002:a17:906:f1d5:: with SMTP id gx21mr70324037ejb.121.1594610879299; Sun, 12 Jul 2020 20:27:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594610879; cv=none; d=google.com; s=arc-20160816; b=ioGyAlGRM+tCd96jhstBOqylOfUr2ny212Gt9MZeKcoyNzW36yrluruUtzx3aCjxSn MyDi/Epvjl9qhWzYOxeg5h+hWC6AhTpUrJ+fODLNLPSLnJoAY2bjoB2YbIaPJnt5hw3O 0xAM48ZOSOt48pnpOz7jLll+2Hwyq6cVL3rtYlONSs3JIg6AeIcV3KMVGlVioz/6TNRB TqX7fm6EL0eB0851jSOkKMYqqETuiqL4dtJJbD9AkatZM9nxUnm//lHnEePGrq5YVitk Gl06xVKrJqK/W/dXJX0VNixDUCmyahhW2ksK7RDdjLM4KUxogmXvm9fG/rK28kFETQI/ lMnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8jdJe8owoYkY3u9O3t8b2q5w2cWQ6E/6FwDioMeh04w=; b=Ehp0zvk/h1Ubv1EhcY6XSmIGhMBB3Ge302OtxBJmYJpvXUnyMY6YgFBVh+cUkzA5kD PsOw0W86tJiFyjaOjy1BgIFoI5b1CgiR/4az3phpRlpXel1Pfhx3u1cFgNRP1q50wt40 kUoSaMbeR99zRIwoDgc4RxBa3vUsdV8INYWCraZjyJrP5EYUvCTEPQzkhc65KizUo8qg OcUE/dRkU/jgOWzKvUP5hwKxQqIGrsoHnZ9KCnsK3cJ8oNSnJ3ixFpz0WLH/cCWmJsNe zc7yY0EMVORiU1EO2S0ILw88rZNPa47nCXBqSIr6e28WyhFExS5EG0DHhGgmXCosRhgu AU6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="F45/0Z3D"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l1si8850498edv.381.2020.07.12.20.27.36; Sun, 12 Jul 2020 20:27:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="F45/0Z3D"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726523AbgGMD1U (ORCPT + 99 others); Sun, 12 Jul 2020 23:27:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:44664 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726261AbgGMD1U (ORCPT ); Sun, 12 Jul 2020 23:27:20 -0400 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 636D520725; Mon, 13 Jul 2020 03:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594610840; bh=STGp2ZUz63RRCqrXyG2JLhnXkAw6U/ZZfYgZku3W/4E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F45/0Z3DlK6+GbH0tVFdt/4eAOjBWuSZITdtmPRqyIMefhsO0jdqOa9ruSU5gZbWB OmJ2+sUrWYtjbDk7bYPM4Y7E/mnBhfCyqe903s3wknvv69y1i61PNVW0EmYdtJnY4w F+Yv66JUrqKCU/cEGzUuqykovw0sHAAl5CWnBkpI= Date: Mon, 13 Jul 2020 11:27:15 +0800 From: Shawn Guo To: Bjorn Helgaas Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas , Russell King , Sascha Hauer , kernel@pengutronix.de, Fabio Estevam , linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] ARM: imx: Remove imx_add_imx_dma() unused irq_err argument Message-ID: <20200713032706.GE21277@dragon> References: <20200701221040.3667868-1-helgaas@kernel.org> <20200701221040.3667868-2-helgaas@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200701221040.3667868-2-helgaas@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 01, 2020 at 05:10:39PM -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > No callers of imx_add_imx_dma() need an error IRQ, so they supply 0 as > "irq_err", which means we register a resource of IRQ 0, which is invalid > and causes a warning if used. > > Remove the "irq_err" argument altogether so there's no chance of trying to > use the invalid IRQ 0. > > Fixes: a85a6c86c25be ("driver core: platform: Clarify that IRQ 0 is invalid") > Signed-off-by: Bjorn Helgaas > Cc: Russell King > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: kernel@pengutronix.de > Cc: Fabio Estevam > Cc: linux-imx@nxp.com > Cc: linux-arm-kernel@lists.infradead.org Applied, thanks.