Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp752794ybh; Sun, 12 Jul 2020 23:29:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzVBTloW4XgnTBVjL70imVdh0zePx+PnEkgt21T/xa7fEakXLktvIh8KsRsSqT8eo9lBBXl X-Received: by 2002:a50:acc5:: with SMTP id x63mr66066822edc.99.1594621759114; Sun, 12 Jul 2020 23:29:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594621759; cv=none; d=google.com; s=arc-20160816; b=PaTk/8Gpk4wk22vlyX0pzrXBymF0ZXuy3TUJDkX/c8pXfHQdxW0DYbkalndvdYdqmI PirnWPBnbMQhQkjva6YtN9rdTfMs3t2KwAS5WzveWSrjl71GcjCWnQTSUZwRYoK86APj XvRIdMoJk2icqWdI4bvVJ10IWHUPRUCInD52zlDpCYYkRWKqAivJZcW07DiM+siTF8pj pgR+tQFP5emX9Wy4ERzITT19kLNWisCaLr+HlrSos6AofLnR13+y93jKlTZ18tka9AFv OsNrtSKIX9gZP4YvoD+ReoErgCAzO+Vm60GIq5Y6wBQFGEFLeNa1XUZK9JIPM96fnbCA rd/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=ayuowYu5IPucW5aRue9WTdaBBAU1leq/WnJlYENtKcQ=; b=g7U+mjiXSJ16vpub/UihAWkDlHFVMnii/JNvR40dPK9UsfpEUGY2UYGQD+2vvFmJ3d y4PBIWfIr0qNypT19mVzCiS58bWJ1OAdLsIPeij2NTaWoFrRh4KWbAkRksv0o4XPvmqq J9mM2LBQdDoPw1Ga8C37uHyz309k8pLkiVGtT/L+FQfqAHH16c8udjBA/gb730bpXEiL nWyfDUXFony/ILySa9XgCpA9bFX17QXUR6E03mz6yrTN+3abj/d33CBS5QtwKfwEzMTv hweGjl3kQdpLpdXY6MlfWwwdiK8gjdL7qNqC66Z1c/yoImfx2nFCZ3fx5Bpu2YYD/KrA 8Gjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn14si11245013ejc.697.2020.07.12.23.28.56; Sun, 12 Jul 2020 23:29:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728847AbgGMGZ4 (ORCPT + 99 others); Mon, 13 Jul 2020 02:25:56 -0400 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]:57161 "EHLO out30-44.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725804AbgGMGZz (ORCPT ); Mon, 13 Jul 2020 02:25:55 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04427;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0U2X9-sE_1594621552; Received: from localhost(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0U2X9-sE_1594621552) by smtp.aliyun-inc.com(127.0.0.1); Mon, 13 Jul 2020 14:25:52 +0800 From: Baolin Wang To: kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me Cc: baolin.wang@linux.alibaba.com, baolin.wang7@gmail.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] nvme: Remove redundant validation in nvme_start_ctrl() Date: Mon, 13 Jul 2020 14:25:21 +0800 Message-Id: <710eb90d9c1c125bdb37aae31ddc41a0f9782fa6.1594621435.git.baolin.wang@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We've already validated the 'kato' in nvme_start_keep_alive(), thus no need to validate it again in nvme_start_ctrl(). Remove it. Signed-off-by: Baolin Wang --- drivers/nvme/host/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 3d00ea4..a95e26e 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -4313,8 +4313,7 @@ void nvme_stop_ctrl(struct nvme_ctrl *ctrl) void nvme_start_ctrl(struct nvme_ctrl *ctrl) { - if (ctrl->kato) - nvme_start_keep_alive(ctrl); + nvme_start_keep_alive(ctrl); nvme_enable_aen(ctrl); -- 1.8.3.1