Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 13 Jul 2020 14:48:52 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Richard Zhu <hongxing.zhu@nxp.com>
Cc:     linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6qdl: only enable pcie in the pcie dts file
Message-ID: <20200713064851.GH12113@dragon>
References: <1594025081-2353-1-git-send-email-hongxing.zhu@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1594025081-2353-1-git-send-email-hongxing.zhu@nxp.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 06, 2020 at 04:44:41PM +0800, Richard Zhu wrote:
> Since iMX6Q/DL PCIe has the PM limitation (ERR005723 "PCIe PCIe does
> not support L2 Power Down").
> System suspend/resume would be broken by PCIe, if PCIe is enabled.
> Only enable PCIe in the xxx-pcie.dts files to avoid the brokens when
> other xxx.dtb files are used on sabresd and sabreauto boards.
> 
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> ---
>  arch/arm/boot/dts/Makefile                  |  4 ++++
>  arch/arm/boot/dts/imx6dl-sabreauto-pcie.dts | 12 ++++++++++++
>  arch/arm/boot/dts/imx6dl-sabresd-pcie.dts   | 12 ++++++++++++
>  arch/arm/boot/dts/imx6q-sabreauto-pcie.dts  | 12 ++++++++++++
>  arch/arm/boot/dts/imx6q-sabresd-pcie.dts    | 12 ++++++++++++
>  arch/arm/boot/dts/imx6qdl-sabreauto.dtsi    |  4 ----
>  arch/arm/boot/dts/imx6qdl-sabresd.dtsi      |  1 -
>  7 files changed, 52 insertions(+), 5 deletions(-)
>  create mode 100644 arch/arm/boot/dts/imx6dl-sabreauto-pcie.dts
>  create mode 100644 arch/arm/boot/dts/imx6dl-sabresd-pcie.dts
>  create mode 100644 arch/arm/boot/dts/imx6q-sabreauto-pcie.dts
>  create mode 100644 arch/arm/boot/dts/imx6q-sabresd-pcie.dts

No.  There are hundreds of boards based on i.MX6Q/DL.  We are not going
to maintain a -pcie.dts for every single one of them.

Shawn