Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 13 Jul 2020 15:34:22 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Chris Healy <cphealy@gmail.com>
Cc:     robh+dt@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
        linux-imx@nxp.com, stefan@agner.ch, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        andrew@lunn.ch
Subject: Re: [PATCH v2] ARM: dts: ZII: update MDIO speed and preamble
Message-ID: <20200713071957.GL12113@dragon>
References: <20200708002500.4563-1-cphealy@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200708002500.4563-1-cphealy@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 07, 2020 at 05:25:00PM -0700, Chris Healy wrote:
> Update MDIO configuration with ZII devices to fully utilize
> MDIO endpoint capabilities.  All devices support 12.5MHz clock and
> don't require MDIO preable.
> 
> Signed-off-by: Chris Healy <cphealy@gmail.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> ---
> v2:
> - Fix subject line to reference ZII:
> - Get rid of "=<1>;" from suppress-preamble lines
> 
>  arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi   | 2 ++
>  arch/arm/boot/dts/vf610-zii-cfu1.dts      | 2 ++
>  arch/arm/boot/dts/vf610-zii-dev.dtsi      | 2 ++
>  arch/arm/boot/dts/vf610-zii-spb4.dts      | 2 ++
>  arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts  | 2 ++
>  arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts | 2 ++
>  6 files changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> index 20350e803377..58cc421042e1 100644
> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> @@ -720,6 +720,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;

We usually have 'status' at end of property list, so please move them
up.

Shawn

>  
>  		switch: switch@0 {
>  			compatible = "marvell,mv88e6085";
> diff --git a/arch/arm/boot/dts/vf610-zii-cfu1.dts b/arch/arm/boot/dts/vf610-zii-cfu1.dts
> index ce1920c052fc..c27cacbe6a73 100644
> --- a/arch/arm/boot/dts/vf610-zii-cfu1.dts
> +++ b/arch/arm/boot/dts/vf610-zii-cfu1.dts
> @@ -159,6 +159,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  
>  		switch0: switch0@0 {
>  			compatible = "marvell,mv88e6085";
> diff --git a/arch/arm/boot/dts/vf610-zii-dev.dtsi b/arch/arm/boot/dts/vf610-zii-dev.dtsi
> index 95d0060fb56c..9694d3b53607 100644
> --- a/arch/arm/boot/dts/vf610-zii-dev.dtsi
> +++ b/arch/arm/boot/dts/vf610-zii-dev.dtsi
> @@ -138,6 +138,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  	};
>  };
>  
> diff --git a/arch/arm/boot/dts/vf610-zii-spb4.dts b/arch/arm/boot/dts/vf610-zii-spb4.dts
> index 55b4201e27f6..d2ad07ed5318 100644
> --- a/arch/arm/boot/dts/vf610-zii-spb4.dts
> +++ b/arch/arm/boot/dts/vf610-zii-spb4.dts
> @@ -120,6 +120,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  
>  		switch0: switch0@0 {
>  			compatible = "marvell,mv88e6190";
> diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> index a6c22a79779e..0bb3dcff0b79 100644
> --- a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> +++ b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> @@ -106,6 +106,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  
>  		switch0: switch0@0 {
>  			compatible = "marvell,mv88e6190";
> diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> index 3d05c894bdc0..e12e11805b71 100644
> --- a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> +++ b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> @@ -134,6 +134,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  
>  		switch0: switch0@0 {
>  			compatible = "marvell,mv88e6190";
> -- 
> 2.21.3
>