Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp802832ybh; Mon, 13 Jul 2020 01:19:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8nq9jEfiy2zeEE+8Awy518bKh1d/RaQSJHSyqDULIEyHc0xevPLt79TnJ0bcGWkJzyx3g X-Received: by 2002:a05:6402:363:: with SMTP id s3mr77034363edw.238.1594628341713; Mon, 13 Jul 2020 01:19:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594628341; cv=none; d=google.com; s=arc-20160816; b=OCad62hVnOpIK2MCcBCS3bVdHm27FMFYQla8UHB9D0+fMlg4lHVDs5zApN2b24lBQZ jR/ObY/ZfESzCEQ1CkiuYlJeUwaXuMaM85sq5hcqnSEdfRNpidM23jxcHmdharB5TUqe PAcuKsOMGzguGdWs8kSRP7rKua6UB5/7+lDIqTSPvIKvlQ9BnqAF/FwZPomboG81cV9g 3bBqBWXNX26vOvrcMTz3RKnWAxqrwxUv15DyZCsKqH3D0+/4xVtvwnwgbznXnn5omZqd sOHoqEiaKvGlCOn3w9MF719nwhcPCXcg25z4voE/xq/sPCkRK1ZjaJIRtkC5EORJfeK+ StPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=9JP1Yyp+DTsbRDEveTS8YwrT8f2VEO8CdIRFCeUgVxQ=; b=pccM5RvU1Cn2SmuJfFZ4ciIElsHQt3tXEV8JhL2zgsYCnEYkgE6JuIOmsBMER7LqKd KS/7n1GHOnVglLVj/CbGUTZnM0FFpu0QlgSMS7yVqDYEIOWYJZqG/cXYiDaFr5e1Keg0 U941ecM2+TAkX/GIXSim/KBzRhmHxhtrEoSxjpib6CS5pdTSBIPLZJyL3mK1RWz/VuTL SFde3KocfwQbLQRKHvn7jBz7Es6e/LWuO2JPCNqpCTeubR1uBb9Fad10WmeDlTuLFsHZ Ux5EnXFXJG6P6FTfrEsEhznqRuiGc1QtX6kcsdbWxvVBYhcP7Sb6bqfykn4h1MON3oU6 wWIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cloud.ionos.com header.s=google header.b=XLao+p1V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o5si8483124edj.37.2020.07.13.01.18.37; Mon, 13 Jul 2020 01:19:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cloud.ionos.com header.s=google header.b=XLao+p1V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727829AbgGMISU (ORCPT + 99 others); Mon, 13 Jul 2020 04:18:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725969AbgGMIST (ORCPT ); Mon, 13 Jul 2020 04:18:19 -0400 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79A0DC061794 for ; Mon, 13 Jul 2020 01:18:19 -0700 (PDT) Received: by mail-ej1-x641.google.com with SMTP id dr13so15502956ejc.3 for ; Mon, 13 Jul 2020 01:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9JP1Yyp+DTsbRDEveTS8YwrT8f2VEO8CdIRFCeUgVxQ=; b=XLao+p1V5JORtXNlcnEOcYEcU8EJSO/lRaYhZO3XmgfuF21T31seX/KeejsgSYB/dH 9Mtzc6sD0ywKjPrk4YHzeSWPbmFx4cZwR8sgmBUOfTXTsukGhDYlx0yeT7wzCN3UPuIu u48JA1UwjkiLL7Du7ODyx85cRfcRXQfHsGYEmhYjSXUTxNFnqEywTwpxHWMy1ugojrgK pcbagL35jFPmlEmuAhruE3o6KM6BKgpVutSeb0ABNj5aUbzZxe0DCJhMIR9mB1thYzO3 eqxYHou/QhiKuyswI8nlJrw5jmV3dqxdqWYuU6h1iLGNgu56Fjd91dRiWupz2EBmGJuk 6Vew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9JP1Yyp+DTsbRDEveTS8YwrT8f2VEO8CdIRFCeUgVxQ=; b=nh+5BwSFzHaeXTwPlDb5FE8u7WuAXaf66p8UTqm/4MIhnAgZDm36KmjJLMvfIDwJ9O Zn6Kc8fGG8NFleWrHcUtvLpb6FYi8KWV7yIzMWAx4Ttb7gURDUDsjETZLL5wxHmS2DrS OXlK7BfXEL7N+qEoOaMLrhehpZNh6OiG85SEXBY5wvd736dtKJzPJfAMfxV+QAZwuo9K j3vpCdToTq/ADXcPkM1t5B5jJvY4xY1wzTMt1jkin/70m108H8s8tvVq7Lypqbs4Y4eD KY2QdQi+oqPs6xnSRGtL5J/PGNozt7bw/NsocZrvbRSLhZgFMp2ZduZFea1UzSjcv1Lm 8WFg== X-Gm-Message-State: AOAM530dsrScskUBB19FXM4/5AzxlAhM+BBtQJ7y/eOiT8yi45IpvNdm kLPYsaW2rPFS38tfUi2OXCG1QgVfrwFgVD8257lIHDDA+Mr/Jg== X-Received: by 2002:a17:906:3b01:: with SMTP id g1mr37201239ejf.353.1594628298066; Mon, 13 Jul 2020 01:18:18 -0700 (PDT) MIME-Version: 1.0 References: <20200713080001.128044-1-lee.jones@linaro.org> <20200713080001.128044-11-lee.jones@linaro.org> In-Reply-To: <20200713080001.128044-11-lee.jones@linaro.org> From: Jinpu Wang Date: Mon, 13 Jul 2020 10:18:07 +0200 Message-ID: Subject: Re: [PATCH v2 10/24] scsi: pm8001: pm8001_ctl: Provide descriptions for the many undocumented 'attr's To: Lee Jones Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-kernel@vger.kernel.org, Linux SCSI Mailinglist Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 13, 2020 at 10:00 AM Lee Jones wrote: > > ... even if they are completely unused. > > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/pm8001/pm8001_ctl.c:56: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_mpi_interface_rev_show' > drivers/scsi/pm8001/pm8001_ctl.c:81: warning: Function parameter or member 'attr' not described in 'controller_fatal_error_show' > drivers/scsi/pm8001/pm8001_ctl.c:100: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_fw_version_show' > drivers/scsi/pm8001/pm8001_ctl.c:130: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_ila_version_show' > drivers/scsi/pm8001/pm8001_ctl.c:155: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_inactive_fw_version_show' > drivers/scsi/pm8001/pm8001_ctl.c:181: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_max_out_io_show' > drivers/scsi/pm8001/pm8001_ctl.c:204: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_max_devices_show' > drivers/scsi/pm8001/pm8001_ctl.c:230: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_max_sg_list_show' > drivers/scsi/pm8001/pm8001_ctl.c:274: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_sas_spec_support_show' > drivers/scsi/pm8001/pm8001_ctl.c:303: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_host_sas_address_show' > drivers/scsi/pm8001/pm8001_ctl.c:322: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_logging_level_show' > drivers/scsi/pm8001/pm8001_ctl.c:355: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_aap_log_show' > drivers/scsi/pm8001/pm8001_ctl.c:390: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_ib_queue_log_show' > drivers/scsi/pm8001/pm8001_ctl.c:423: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_ob_queue_log_show' > drivers/scsi/pm8001/pm8001_ctl.c:454: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_bios_version_show' > drivers/scsi/pm8001/pm8001_ctl.c:492: warning: Function parameter or member 'attr' not described in 'event_log_size_show' > drivers/scsi/pm8001/pm8001_ctl.c:510: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_iop_log_show' > drivers/scsi/pm8001/pm8001_ctl.c:548: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_fatal_log_show' > drivers/scsi/pm8001/pm8001_ctl.c:566: warning: Function parameter or member 'attr' not described in 'non_fatal_log_show' > drivers/scsi/pm8001/pm8001_ctl.c:609: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_gsm_log_show' > > Cc: Jack Wang > Signed-off-by: Lee Jones good to have kernel doc warning clean. Thanks! Acked-by: Jack Wang