Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: ECD8d+6VRERVz1NexPRZLAD16cqy0DLQfBe3yBgY8lt1YIdTHViZQs3MDURNGkXxKe684enxaR
 QyJ+hk5S46YA==
IronPort-SDR: W0/N1s0QOrFeETf1Nu+GSGKpwp7WPsF7Kg8kkCMvvHqU/8uN4iZ6YsxgiZY1oeB8A8vM2KRCSC
 uWVo3KQ3dYfQ==
Subject: Re: [PATCH v10 04/15] perf evlist: introduce control file descriptors
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <4af50c95-36f6-7a61-5a22-2949970fe7a5@linux.intel.com>
 <92aa73c7-4148-a45d-6964-983fe1654d1e@linux.intel.com>
 <CAM9d7cj86U7xcmAdiKjEKNp+qS_YAP72xKusAjLWGo2frxpL_A@mail.gmail.com>
From:   Alexey Budankov <alexey.budankov@linux.intel.com>
Organization: Intel Corp.
Message-ID: <823145dc-f293-166e-290b-076c1254fe17@linux.intel.com>
Date:   Mon, 13 Jul 2020 11:16:06 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CAM9d7cj86U7xcmAdiKjEKNp+qS_YAP72xKusAjLWGo2frxpL_A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 13.07.2020 6:13, Namhyung Kim wrote:
> Hello,
> 
> On Wed, Jul 8, 2020 at 4:47 PM Alexey Budankov
> <alexey.budankov@linux.intel.com> wrote:
>>
>>
>> Define and initialize control file descriptors.
>>
>> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
>> ---
>>  tools/perf/util/evlist.c | 3 +++
>>  tools/perf/util/evlist.h | 5 +++++
>>  2 files changed, 8 insertions(+)
>>
>> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
>> index bcbe0cb8482e..36eb50aba1f5 100644
>> --- a/tools/perf/util/evlist.c
>> +++ b/tools/perf/util/evlist.c
>> @@ -63,6 +63,9 @@ void evlist__init(struct evlist *evlist, struct perf_cpu_map *cpus,
>>         perf_evlist__set_maps(&evlist->core, cpus, threads);
>>         evlist->workload.pid = -1;
>>         evlist->bkw_mmap_state = BKW_MMAP_NOTREADY;
>> +       evlist->ctl_fd.fd = -1;
>> +       evlist->ctl_fd.ack = -1;
>> +       evlist->ctl_fd.pos = -1;
>>  }
>>
>>  struct evlist *evlist__new(void)
>> diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h
>> index 38901c0d1599..2caf19fb87a8 100644
>> --- a/tools/perf/util/evlist.h
>> +++ b/tools/perf/util/evlist.h
>> @@ -74,6 +74,11 @@ struct evlist {
>>                 pthread_t               th;
>>                 volatile int            done;
>>         } thread;
>> +       struct {
>> +               int     fd;
>> +               int     ack;
>> +               int     pos;
>> +       } ctl_fd;
> 
> Could you please add brief descriptions for each field
> in the comment?  It's not obvious to me other than fd.

Ok. In v11.

Alexei