Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200711114409.9911-1-rikard.falkeborn@gmail.com>
In-Reply-To: <20200711114409.9911-1-rikard.falkeborn@gmail.com>
From:   Pi-Hsun Shih <pihsun@chromium.org>
Date:   Mon, 13 Jul 2020 16:55:56 +0800
Message-ID: <CANdKZ0f471hRgFJS1EDJ81xfaom6UKV+7RLVEC9T5x9vrt22Nw@mail.gmail.com>
Subject: Re: [PATCH] regulator: cros-ec: Constify cros_ec_regulator_voltage_ops
To:     Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Acked-by: Pi-Hsun Shih <pihsun@chromium.org>

On Sat, Jul 11, 2020 at 7:44 PM Rikard Falkeborn
<rikard.falkeborn@gmail.com> wrote:
>
> It is never modified, so make it const to allow the compiler to put it
> in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
>  drivers/regulator/cros-ec-regulator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/cros-ec-regulator.c b/drivers/regulator/cros-ec-regulator.c
> index 35f97246bc48..eeed5aac3f32 100644
> --- a/drivers/regulator/cros-ec-regulator.c
> +++ b/drivers/regulator/cros-ec-regulator.c
> @@ -142,7 +142,7 @@ static int cros_ec_regulator_set_voltage(struct regulator_dev *dev, int min_uV,
>                            sizeof(cmd), NULL, 0);
>  }
>
> -static struct regulator_ops cros_ec_regulator_voltage_ops = {
> +static const struct regulator_ops cros_ec_regulator_voltage_ops = {
>         .enable = cros_ec_regulator_enable,
>         .disable = cros_ec_regulator_disable,
>         .is_enabled = cros_ec_regulator_is_enabled,
> --
> 2.27.0
>