Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To:     Vinod Koul <vkoul@kernel.org>
CC:     "kishon@ti.com" <kishon@ti.com>,
        "wsa+renesas@sang-engineering.com" <wsa+renesas@sang-engineering.com>,
        "geert+renesas@glider.be" <geert+renesas@glider.be>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] phy: renesas: rcar-gen3-usb2: fix SError happen if
 DEBUG_SHIRQ is enabled
Thread-Topic: [PATCH] phy: renesas: rcar-gen3-usb2: fix SError happen if
 DEBUG_SHIRQ is enabled
Thread-Index: AQHWVdzOlRKh/M+DfUqZfhc9meFTe6kE/fiAgABPW0A=
Date:   Mon, 13 Jul 2020 10:08:42 +0000
Message-ID: <TY2PR01MB3692AB237DE409457E0E9A07D8600@TY2PR01MB3692.jpnprd01.prod.outlook.com>
References: <1594290978-8205-1-git-send-email-yoshihiro.shimoda.uh@renesas.com>
 <20200713051705.GX34333@vkoul-mobl>
In-Reply-To: <20200713051705.GX34333@vkoul-mobl>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 54907e5f-f460-4c1b-bc81-08d82714b8b2
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2020 10:08:42.3206
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: L2IaYc5X7N1iW1Q/XXeRDMq8xvTq+oXQPPAYxeYwFzlsgWXmGzr4IqfDajxdqwt+hucPnOPDPgotvIEWhsd2UueYsxlGbM1yOpzxiw64eNXgU17WVqmWh8g/XwA0Fiwz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB3934
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Vinod,

> From: Vinod Koul, Sent: Monday, July 13, 2020 2:17 PM
>=20
> Hi Yoshihiro,
>=20
> On 09-07-20, 19:36, Yoshihiro Shimoda wrote:
> > If CONFIG_DEBUG_SHIRQ was enabled, r8a77951-salvator-xs could boot
> > correctly. If we appended "earlycon keep_bootcon" to the kernel
> > command like, we could get kernel log like below.
> >
> >     SError Interrupt on CPU0, code 0xbf000002 -- SError
> >     CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.8.0-rc3-salvator-x-0050=
5-g6c843129e6faaf01 #785
> >     Hardware name: Renesas Salvator-X 2nd version board based on r8a779=
51 (DT)
> >     pstate: 60400085 (nZCv daIf +PAN -UAO BTYPE=3D--)
> >     pc : rcar_gen3_phy_usb2_irq+0x14/0x54
> >     lr : free_irq+0xf4/0x27c
> >
> > This means free_irq() calls the interrupt handler while PM runtime
> > is not getting if DEBUG_SHIRQ is enabled and rcar_gen3_phy_usb2_probe()
> > failed. To fix the issue, add a condition into the interrupt
> > handler to avoid register access if any phys are not initialized.
> >
> > Note that rcar_gen3_is_any_rphy_initialized() was introduced on v5.2.
> > So, if we backports this patch to v5.1 or less, we need to make
> > other way.
>=20
> Should we really check phy is initialized? I think the issue here is
> that you register irq first, so your handler can be invoked. Right fix
> for this would be to move the irq registration to later in the probe
> when we are ready to handle interrupts

Thank you for your review! I think we need to check whether phy is initiali=
zed
even if the irq registration moves to rcar_gen3_phy_usb2_init() because the=
 current
driver will have multiple phy instances. However, moving the irq registrati=
on can be
easy to backport than this patch, I think. So, I'll modify this patch as yo=
u suggested.

Best regards,
Yoshihiro Shiomda