Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp978496ybh; Mon, 13 Jul 2020 06:23:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2UMQkFbVMVpyCRs1r9XgyXNYvZAF5EhoKmGhqiwID2OZx+CCMtI8hZVgUgOa5eZFvvOBa X-Received: by 2002:a17:906:2641:: with SMTP id i1mr68811638ejc.380.1594646579958; Mon, 13 Jul 2020 06:22:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594646579; cv=none; d=google.com; s=arc-20160816; b=w+uO+Vgyu/ZSpDRLroi0l5LqPkMegVpyemJtH3QE203p+rtWu9UFXQt0o9HvyKxUxA wt9dv1gbLUnco3brnDy2w9V7A41Ag+AZl+wbSG8T+p79ZJk9ZL8QF8dqhgc/l1sHFB1g 3bq5cqsksLnSfWO2IpO2F1QjzmGNBYKntLYiX7Di1UoViT7R7imLrXnWaCP+KGcMxOhE wR1V4SoE7Lhz46IjhexdIMDbyb/vFR0SaBr5yN6YpNINpJTUt85SqRN4H4okHbLPe5cP SXtokDE7MJd6WslOv7CT3jIDcPi2IJXJ97Dk77a7P/ThEqQdVRYPKKpHMbvLemiRRzqL +Ijw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=IsCx21R9uOak9QcS7V2jheu5SR94fsyWHn32kBIsdH8=; b=DEJ7o1upsZNtRFYwsaiisLayXPDX8vMH5n0HA7l81mvGg5U3ybKixFfAr4wVxf2CsH VTqVHlX9OcFZ4ssvhZYb5cyGmKxpkQ+UANbk04pok3dl/xpMD5yEEf3U3xpKPfTfWWRh YYprx9FSpKf176izNoAVG6Ef6JJfgW3f3qZ97gFJ3D6EMT0Bb57+1pTFoprgHX8JQVxb AvGQapuhLDxAtSzyxtMW3Y8/x4c8SmLC4NDAhiLsPPGqcNU/BhUYIWEoFA604ey2XlpJ EnSIofYLKsMwJ4Rm6EOye0Fk0YU96hwO50yyLSYyKV/eEUSGCRhUcp9013aJ3RIXuagi UyiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=kG09VKpe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j8si8618877edy.211.2020.07.13.06.22.36; Mon, 13 Jul 2020 06:22:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=kG09VKpe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729854AbgGMNUZ (ORCPT + 99 others); Mon, 13 Jul 2020 09:20:25 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:54502 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729751AbgGMNUY (ORCPT ); Mon, 13 Jul 2020 09:20:24 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 06DDIXOF090700; Mon, 13 Jul 2020 08:18:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1594646313; bh=IsCx21R9uOak9QcS7V2jheu5SR94fsyWHn32kBIsdH8=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=kG09VKpebNsw7WybqlaWAHpeMirfS/GUqi2jbftB9uIIaYJ9PqxqJcJIs+NIwezE9 U90FAyKAh8j4rGyGCXhJjVVutG/ocKEF+pQ4E2UYZqLeH5wsDpPF/PONyPXZZf711n 5as93xlL3tp+ZmR7PyRL/ZTYBUfLxREbZRgmDlhc= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 06DDIXl9092260 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 13 Jul 2020 08:18:33 -0500 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 13 Jul 2020 08:18:33 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 13 Jul 2020 08:18:33 -0500 Received: from sokoban.bb.dnainternet.fi (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 06DDIOXs015417; Mon, 13 Jul 2020 08:18:32 -0500 From: Tero Kristo To: , , CC: , Subject: [PATCHv3 4/4] watchdog: rti-wdt: balance pm runtime enable calls Date: Mon, 13 Jul 2020 16:18:18 +0300 Message-ID: <20200713131818.825-5-t-kristo@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200713131818.825-1-t-kristo@ti.com> References: <20200713131818.825-1-t-kristo@ti.com> MIME-Version: 1.0 Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PM runtime should be disabled in the fail path of probe and when the driver is removed. Fixes: 2d63908bdbfb ("watchdog: Add K3 RTI watchdog support") Signed-off-by: Tero Kristo Reviewed-by: Guenter Roeck --- drivers/watchdog/rti_wdt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/watchdog/rti_wdt.c b/drivers/watchdog/rti_wdt.c index 45dfc546e371..5cc1a1d654b6 100644 --- a/drivers/watchdog/rti_wdt.c +++ b/drivers/watchdog/rti_wdt.c @@ -302,6 +302,7 @@ static int rti_wdt_probe(struct platform_device *pdev) err_iomap: pm_runtime_put_sync(&pdev->dev); + pm_runtime_disable(&pdev->dev); return ret; } @@ -312,6 +313,7 @@ static int rti_wdt_remove(struct platform_device *pdev) watchdog_unregister_device(&wdt->wdd); pm_runtime_put(&pdev->dev); + pm_runtime_disable(&pdev->dev); return 0; } -- 2.17.1 -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki