Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 13 Jul 2020 10:30:40 -0300
From:   Bruno Meneguele <bmeneg@redhat.com>
To:     Petr Mladek <pmladek@suse.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
        Jason@zx2c4.com
Subject: Re: [PATCH v2] doc:kmsg: explictly state the return value in case of
 SEEK_CUR
Message-ID: <20200713133040.GB4730@glitch>
References: <20200710174423.10480-1-bmeneg@redhat.com>
 <20200713022558.GC491026@jagdpanzerIV.localdomain>
 <20200713131509.GC20226@alley>
MIME-Version: 1.0
In-Reply-To: <20200713131509.GC20226@alley>
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="neYutvxvOLaeuPCA"
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--neYutvxvOLaeuPCA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 13, 2020 at 03:15:09PM +0200, Petr Mladek wrote:
> On Mon 2020-07-13 11:25:58, Sergey Senozhatsky wrote:
> > On (20/07/10 14:44), Bruno Meneguele wrote:
> > > The commit 625d3449788f ("Revert "kernel/printk: add kmsg SEEK_CUR
> > > handling"") reverted a change done to the return value in case a SEEK=
_CUR
> > > operation was performed for kmsg buffer based on the fact that differ=
ent
> > > userspace apps were handling the new return value (-ESPIPE) in differ=
ent
> > > ways, breaking them.
> > >=20
> > > At the same time -ESPIPE was the wrong decision because kmsg /does su=
pport/
> > > seek() but doesn't follow the "normal" behavior userspace is used to.
> > > Because of that and also considering the time -EINVAL has been used, =
it was
> > > decided to keep this way to avoid more userspace breakage.
> > >=20
> > > This patch adds an official statement to the kmsg documentation point=
ing to
> > > the current return value for SEEK_CUR, -EINVAL, thus userspace librar=
ies
> > > and apps can refer to it for a definitive guide on what to expect.
> > >=20
> > > Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
> >=20
> > Looks good to me,
> > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
>=20
> The patch is committed in printk/linux.git, branch for-5.9.
>=20
> Thanks for v2.
>=20
> Best Regards,
> Petr
>=20

Thanks Sergey and Petr.

--=20
bmeneg=20
PGP Key: http://bmeneg.com/pubkey.txt

--neYutvxvOLaeuPCA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEdWo6nTbnZdbDmXutYdRkFR+RokMFAl8MYf4ACgkQYdRkFR+R
okO59wf5AYv1JZs5ZKpnv12HJJ1eEtnHywi+AUGzH+TDmlXLq8IE1mwqw+Nfj1TI
k7whD+BozqecifygMC/5yVO166N/D+Aco3kI1LgySTlMXuojuL0OEvrdcKW596Us
A4kDcZrtuzx4fwmKj+SjL07ga2WfE8G8uOtUPtmNl7I4zswayu6Ujh7sJ4trq+1T
wLwU19MzcXw43Xs50lIJNd287SFzrEWQ27Eeif3zYGWFQFZX5VSUkGoRtNudMyCd
kiBvXrzLphGa2hdHLChKGrqwBgKIpQ2GfBUmS5LBQdDkCHgtFfJxNxwrBQBx9NY1
f7TXJmGbxfxEVaAkUpX2E/AkzgUpug==
=jeqx
-----END PGP SIGNATURE-----

--neYutvxvOLaeuPCA--