Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Subject: Re: [PATCH v5 1/2] dt-bindings: phy: add bcm63xx-usbh bindings
From:   =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= <noltari@gmail.com>
In-Reply-To: <20200709221105.GA976808@bogus>
Date:   Mon, 13 Jul 2020 15:55:11 +0200
Cc:     simon@fire.lp0.eu, Jonas Gorski <jonas.gorski@gmail.com>,
        kishon@ti.com, vkoul@kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>,
        bcm-kernel-feedback-list@broadcom.com,
        Philipp Zabel <p.zabel@pengutronix.de>, krzk@kernel.org,
        gregkh@linuxfoundation.org, alcooperx@gmail.com,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <273F7F58-2416-4106-9622-4351711A26B2@gmail.com>
References: <20200619100035.4032596-1-noltari@gmail.com>
 <20200619100035.4032596-2-noltari@gmail.com> <20200709221105.GA976808@bogus>
To:     Rob Herring <robh@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Rob,

If adding "additionalProperties: false=E2=80=9D throws the following =
error, which I don=E2=80=99t understand:
=
/home/noltari/workspace/linux/Documentation/devicetree/bindings/phy/brcm,b=
cm63xx-usbh-phy.example.dt.yaml: usb-phy@10001700: 'clock-names', =
'clocks' do not match any of the regexes: 'pinctrl-[0-9]+=E2=80=99

BTW, is this what you mean? (I added another if section for the cases =
with just 1 clock):
https://gist.github.com/Noltari/9bd94a30e8bcc857d6af87985d7ca010

Best regards,
=C3=81lvaro.

> El 10 jul 2020, a las 0:11, Rob Herring <robh@kernel.org> escribi=C3=B3:=

>=20
> On Fri, Jun 19, 2020 at 12:00:34PM +0200, =C3=81lvaro Fern=C3=A1ndez =
Rojas wrote:
>> Document BCM63xx USBH PHY bindings.
>>=20
>> Signed-off-by: =C3=81lvaro Fern=C3=A1ndez Rojas <noltari@gmail.com>
>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>> v5: no changes.
>> v4: conditionally require 1/2 clocks and fix clock/reset values.
>> v3: no changes.
>> v2: phy-cells changed to 1.
>>=20
>> .../bindings/phy/brcm,bcm63xx-usbh-phy.yaml   | 84 =
+++++++++++++++++++
>> 1 file changed, 84 insertions(+)
>> create mode 100644 =
Documentation/devicetree/bindings/phy/brcm,bcm63xx-usbh-phy.yaml
>>=20
>> diff --git =
a/Documentation/devicetree/bindings/phy/brcm,bcm63xx-usbh-phy.yaml =
b/Documentation/devicetree/bindings/phy/brcm,bcm63xx-usbh-phy.yaml
>> new file mode 100644
>> index 000000000000..f267da6193a9
>> --- /dev/null
>> +++ =
b/Documentation/devicetree/bindings/phy/brcm,bcm63xx-usbh-phy.yaml
>> @@ -0,0 +1,84 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/phy/brcm,bcm63xx-usbh-phy.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>> +
>> +title: BCM63xx USBH PHY
>> +
>> +maintainers:
>> +  - =C3=81lvaro Fern=C3=A1ndez Rojas <noltari@gmail.com>
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - brcm,bcm6318-usbh-phy
>> +      - brcm,bcm6328-usbh-phy
>> +      - brcm,bcm6358-usbh-phy
>> +      - brcm,bcm6362-usbh-phy
>> +      - brcm,bcm6368-usbh-phy
>> +      - brcm,bcm63268-usbh-phy
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 1
>> +
>> +  clock-names:
>> +    const: usbh
>> +
>> +  resets:
>> +    maxItems: 1
>> +
>> +  "#phy-cells":
>> +    const: 1
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - clocks
>> +  - clock-names
>> +  - resets
>> +  - "#phy-cells"
>=20
> You need:
>=20
> additionalProperties: false
>=20
>> +
>> +allOf:
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          enum:
>> +            - brcm,bcm6318-usbh-phy
>> +            - brcm,bcm63268-usbh-phy
>> +    then:
>> +      properties:
>> +        clocks:
>> +          maxItems: 2
>=20
> This doesn't work. The main schema will also be applied and it says=20
> there's 1. The main schema has to cover all the cases and then if/then=20=

> schemas add constraints.
>=20
>> +        clock-names:
>> +          items:
>> +            - const: usbh
>> +            - const: usb_ref
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          enum:
>> +            - brcm,bcm6318-usbh-phy
>> +            - brcm,bcm6328-usbh-phy
>> +            - brcm,bcm6362-usbh-phy
>> +            - brcm,bcm63268-usbh-phy
>> +    then:
>> +      properties:
>> +        power-domains:
>> +          maxItems: 1
>> +      required:
>> +        - power-domains
>> +
>> +examples:
>> +  - |
>> +    usbh: usb-phy@10001700 {
>> +      compatible =3D "brcm,bcm6368-usbh-phy";
>> +      reg =3D <0x10001700 0x38>;
>> +      clocks =3D <&periph_clk 15>;
>> +      clock-names =3D "usbh";
>> +      resets =3D <&periph_rst 12>;
>> +      #phy-cells =3D <1>;
>> +    };
>> --=20
>> 2.27.0