Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1001114ybh; Mon, 13 Jul 2020 07:00:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyWRytuOYWt3eM9Zbd3vXuWHwwTUXa0biDcOqzl8k/5Jh4KC4NlPR5i8fV2IvsjZ5KGSICi X-Received: by 2002:a17:906:6004:: with SMTP id o4mr75914862ejj.411.1594648817182; Mon, 13 Jul 2020 07:00:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594648817; cv=none; d=google.com; s=arc-20160816; b=ZUc2fdGejOmbw/VedE39IZHAYPmy7R1+/pMs+uV1FWqxBaM2cnvhrfsloB7bH5FyOI doUGqbI0zqPHN6wgeQCKTSuQsDzicYWYJMyUdeXU695myxGLbtCCSfmD82XTENIr45/0 4laOhZw47NV7QOPgGA8S0uGx3aRuhA+DiztjZ8RbRx/h0YMljhxGqfeO87FWmEBrkQlH 5XKRnXbFMGLDVGxCkQY7ZfkLlU3OCvAwhPgsSgrfY5gD5msIDjUgZPaqgjTa7mIcSI/+ kObVBcCcfgTFhmGkm6auMhtoTt4xLKHEHTW20icQnIDR8I32liHSlo9vRCvcrTD6E+Ti X9Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=g6VVAwVRVtwu7nEhph88ZeKaTSJUHOPhCypGzCHi2LE=; b=rfU+tRLTKyPSREnKsyFAhWp1HlaSh7EN7ig35NrG/2X0ApmOrSBa/UZF8GhVFIojLJ nC00tC9cQ9MJo6Jwf8roequ5V7BIi1ZFf6slJDPz7jvwXNc2EjMywPOM+WwHXI2UVuHy Pwx4QOuIk2NQ6vLC1q7WpiGpOsksD1zu5h2doLlLk9Blu6vVu0Sy1EnJGHFKe4hnSAQj NW7/PdC+dbElBHFD1TW4JGIBorDZsq68pcFBWNdg2Verozr6zeddmPIEsf8aYORsmYqc owNpc5be8f+yZOLVFpTM1JgrRganQv5w3tF5mhUuo+J/mnRXBDQ273um+bRE93YhLGdX G4KQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j22si9717293eds.273.2020.07.13.06.59.53; Mon, 13 Jul 2020 07:00:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729857AbgGMN5F (ORCPT + 99 others); Mon, 13 Jul 2020 09:57:05 -0400 Received: from foss.arm.com ([217.140.110.172]:36394 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729457AbgGMN5E (ORCPT ); Mon, 13 Jul 2020 09:57:04 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8C42B30E; Mon, 13 Jul 2020 06:57:04 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A59213F7BB; Mon, 13 Jul 2020 06:57:03 -0700 (PDT) Date: Mon, 13 Jul 2020 14:56:58 +0100 From: Lorenzo Pieralisi To: Bharat Kumar Gogada Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, bhelgaas@google.com, robh@kernel.org, maz@kernel.org Subject: Re: [PATCH v9 0/2] Adding support for Versal CPM as Root Port driver Message-ID: <20200713135658.GA27845@e121166-lin.cambridge.arm.com> References: <1592312214-9347-1-git-send-email-bharat.kumar.gogada@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1592312214-9347-1-git-send-email-bharat.kumar.gogada@xilinx.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 16, 2020 at 06:26:52PM +0530, Bharat Kumar Gogada wrote: > - Adding support for Versal CPM as Root port. > - The Versal ACAP devices include CCIX-PCIe Module (CPM). The integrated > block for CPM along with the integrated bridge can function > as PCIe Root Port. > - Versal CPM uses GICv3 ITS feature for assigning MSI/MSI-X > vectors and handling MSI/MSI-X interrupts. > - Bridge error and legacy interrupts in Versal CPM are handled using > Versal CPM specific interrupt line. > > Changes for v9: > - Removed interrupt enablement outside irqchip flow as suggested > by Marc. > - Removed using WARN_ON in if statement. > > Bharat Kumar Gogada (2): > PCI: xilinx-cpm: Add YAML schemas for Versal CPM Root Port > PCI: xilinx-cpm: Add Versal CPM Root Port driver > > .../devicetree/bindings/pci/xilinx-versal-cpm.yaml | 99 ++++ > drivers/pci/controller/Kconfig | 8 + > drivers/pci/controller/Makefile | 1 + > drivers/pci/controller/pcie-xilinx-cpm.c | 615 +++++++++++++++++++++ > 4 files changed, 723 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml > create mode 100644 drivers/pci/controller/pcie-xilinx-cpm.c Applied to pci/xilinx (I removed a function kerneldoc comment (xilinx_cpm_pcie_clear_err_interrupts()) since it was not matching the function name and honestly it is not really needed) for v5.9. Thanks, Lorenzo