Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Subject: Re: [PATCH v5 2/2] phy: bcm63xx-usbh: Add BCM63xx USBH driver
From:   =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= <noltari@gmail.com>
In-Reply-To: <20200713055122.GA34333@vkoul-mobl>
Date:   Mon, 13 Jul 2020 15:59:59 +0200
Cc:     simon@fire.lp0.eu, Jonas Gorski <jonas.gorski@gmail.com>,
        kishon@ti.com, robh+dt@kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>,
        bcm-kernel-feedback-list@broadcom.com,
        Philipp Zabel <p.zabel@pengutronix.de>, krzk@kernel.org,
        gregkh@linuxfoundation.org, alcooperx@gmail.com,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <A0B096B5-A130-44AA-8CC3-6AD136B5107F@gmail.com>
References: <20200619100035.4032596-1-noltari@gmail.com>
 <20200619100035.4032596-3-noltari@gmail.com>
 <20200713055122.GA34333@vkoul-mobl>
To:     Vinod Koul <vkoul@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Vinod,

> El 13 jul 2020, a las 7:51, Vinod Koul <vkoul@kernel.org> escribi=C3=B3:=

>=20
> On 19-06-20, 12:00, =C3=81lvaro Fern=C3=A1ndez Rojas wrote:
>> Add BCM63xx USBH PHY driver for BMIPS.
>>=20
>> Signed-off-by: =C3=81lvaro Fern=C3=A1ndez Rojas <noltari@gmail.com>
>> ---
>> v5: use devm_reset_control_get_exclusive.
>> v4: several improvements:
>>  - Use devm_platform_ioremap_resource.
>>  - Code cleanups.
>>  - Improve device mode config:
>>    - Move USBH_SWAP_CONTROL device mode value to variant variable.
>>    - Set USBH_UTMI_CONTROL1 register value (variant variable).
>> v3: introduce changes suggested by Florian:
>>  - Add support for device mode.
>> v2: introduce changes suggested by Florian:
>>  - Drop OF dependency (use device_get_match_data).
>>  - Drop __initconst from variant tables.
>>  - Use devm_clk_get_optional.
>>=20
>> drivers/phy/broadcom/Kconfig            |   9 +
>> drivers/phy/broadcom/Makefile           |   1 +
>> drivers/phy/broadcom/phy-bcm63xx-usbh.c | 457 =
++++++++++++++++++++++++
>> 3 files changed, 467 insertions(+)
>> create mode 100644 drivers/phy/broadcom/phy-bcm63xx-usbh.c
>>=20
>> diff --git a/drivers/phy/broadcom/Kconfig =
b/drivers/phy/broadcom/Kconfig
>> index b29f11c19155..a7889df8c541 100644
>> --- a/drivers/phy/broadcom/Kconfig
>> +++ b/drivers/phy/broadcom/Kconfig
>> @@ -2,6 +2,15 @@
>> #
>> # Phy drivers for Broadcom platforms
>> #
>> +config PHY_BCM63XX_USBH
>> +	tristate "BCM63xx USBH PHY driver"
>> +	depends on BMIPS_GENERIC || COMPILE_TEST
>> +	select GENERIC_PHY
>> +	default BMIPS_GENERIC
>=20
> you depend on BMIPS_GENERIC and also use as default?

PHY_CYGNUS_PCIE, PHY_BCM_SR_USB, PHY_NS2_USB_DRD, PHY_BRCM_USB and =
PHY_BCM_SR_PCIE are doing that, so I just copied it =C2=AF\_(=E3=83=84)_/=C2=
=AF.
I will remove the default since there are other SoCs in BMIPS_GENERIC =
that won=E2=80=99t need this.

>=20
>> +static int __init bcm63xx_usbh_phy_probe(struct platform_device =
*pdev)
>> +{
>> +	struct device *dev =3D &pdev->dev;
>> +	struct bcm63xx_usbh_phy	*usbh;
>> +	const struct bcm63xx_usbh_phy_variant *variant;
>> +	struct phy *phy;
>> +	struct phy_provider *phy_provider;
>> +
>> +	usbh =3D devm_kzalloc(dev, sizeof(*usbh), GFP_KERNEL);
>> +	if (!usbh)
>> +		return -ENOMEM;
>> +
>> +	variant =3D device_get_match_data(dev);
>> +	if (!variant)
>> +		return -EINVAL;
>> +	usbh->variant =3D variant;
>> +
>> +	usbh->base =3D devm_platform_ioremap_resource(pdev, 0);
>> +	if (IS_ERR(usbh->base))
>> +		return PTR_ERR(usbh->base);
>> +
>> +	usbh->reset =3D devm_reset_control_get_exclusive(dev, NULL);
>> +	if (IS_ERR(usbh->reset)) {
>> +		if (PTR_ERR(usbh->reset) !=3D -EPROBE_DEFER)
>> +			dev_err(dev, "failed to get reset\n");
>> +		return PTR_ERR(usbh->reset);
>> +	}
>> +
>> +	usbh->usbh_clk =3D devm_clk_get_optional(dev, "usbh");
>> +	if (IS_ERR(usbh->usbh_clk))
>> +		return PTR_ERR(usbh->usbh_clk);
>> +
>> +	usbh->usb_ref_clk =3D devm_clk_get_optional(dev, "usb_ref");
>> +	if (IS_ERR(usbh->usb_ref_clk))
>> +		return PTR_ERR(usbh->usb_ref_clk);
>> +
>> +	phy =3D devm_phy_create(dev, NULL, &bcm63xx_usbh_phy_ops);
>> +	if (IS_ERR(phy)) {
>> +		dev_err(dev, "failed to create PHY\n");
>> +		return PTR_ERR(phy);
>> +	}
>> +
>> +	platform_set_drvdata(pdev, usbh);
>> +	phy_set_drvdata(phy, usbh);
>> +
>> +	phy_provider =3D devm_of_phy_provider_register(dev,
>> +						     =
bcm63xx_usbh_phy_xlate);
>> +	if (IS_ERR(phy_provider)) {
>> +		dev_err(dev, "failed to register PHY provider\n");
>> +		return PTR_ERR(phy_provider);
>> +	}
>> +
>> +	dev_info(dev, "Registered BCM63xx USB PHY driver\n");
>=20
> debug level?

Yeah, I will change it.

> --=20
> ~Vinod