Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1010840ybh; Mon, 13 Jul 2020 07:12:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzf4q0UGu30+LcGSpQ/3CSyYlypAz9MqsQdKjzc4u3GxF4cVOIo+QvVML9XBfC2OvoPD5zs X-Received: by 2002:a05:6402:b4b:: with SMTP id bx11mr89488225edb.286.1594649532432; Mon, 13 Jul 2020 07:12:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594649532; cv=none; d=google.com; s=arc-20160816; b=lyShhv/qOGNJq17PoTSchHLX86zFugJpyMjF/5AukhLKhvYOD5Hap6i9DNiVDqxDJ1 Nru1p4CKr0dD8ALvYittzgkx34qU2KYvfSn7Dgz2x0vJdHFmktmG3TYRYDjjNfE0Q2i8 T/+HT+CXKY6PYYo08zc1SOTClyxgj3Vyr8A9NFvAjuddXcGZlfjJqd4o9nm8BoFVqaLx rjShaHhll4KTANzoSKW5IjZ/99vrrWHWWbFf2uAlTlvUKHXxA9UdcuBEbC1akk0pCgnQ AA/OoYZ364fuaOtlrtOL3pxJG92bJ7dHpBQhT4cne5gD+LFKMSijObjbFy7+5cXKKfro K16Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=jFx3xxix0F8ETQCtd//YrBkRHyNpSKt8DUbehu81nM0=; b=UY+9ezpxQq7FmglB/y/ctSdrhlHgbubU8zepVTQllr/gD2wHO//0ODLA7IbO04dioi sJUoAu9EwHrgatdOGHBna/GfncAQyZ6X0EQADjFQGqEw9sK4fwL+mXcZodYYMfIRWcT+ Og0Vqaxp3IYQ6tY/X9zJS7mlRaqXrbVB9UwpUpHACLh4//2e9IvcGPILEi88NNF7eaMC SCaTcBH7qYtRWNgKOSyGYN6/0ECVSd9f8kd8MFsVGj4e+l1czE0w6JFx7BFLBRtp5OnO akjAl85vFVVWFGFv0pc7oBPbFr8/sE0ZldaBzxE8VEFrcBxX4MGAKMpNpGo5DWNo8HsB g1YA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hiQgbcp1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dh7si9493008edb.531.2020.07.13.07.11.49; Mon, 13 Jul 2020 07:12:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hiQgbcp1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729973AbgGMOIt (ORCPT + 99 others); Mon, 13 Jul 2020 10:08:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729689AbgGMOIs (ORCPT ); Mon, 13 Jul 2020 10:08:48 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B19F3C061755; Mon, 13 Jul 2020 07:08:48 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id l12so17341857ejn.10; Mon, 13 Jul 2020 07:08:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=jFx3xxix0F8ETQCtd//YrBkRHyNpSKt8DUbehu81nM0=; b=hiQgbcp1vIlX39x6+QVdnLHGJ77oa5e1fwPasSS2+sV8zK6rqOW6JJ5Z0pNLWQ3fyH odx7b6feIbBRhv8AmdyCvjpu0Er3BjW++icYFpMcdLmYGXMb77ApdSCFPHQ7PYZx99Pk I8Mkstkgkprd7gWz2X1JGLeP0HTASvNy6CqmbcfoqDEDZQChTyxcj63JpPe2R9IPFeT2 /H1agutVggOmAMHTMBd1fVRznJhJOpwoIKMNSwMgPNuLntSS4oJmPdK6ISJkxSSBE833 eVGo5j4lAbf7jgdbIbwlcZJzo8zXY3jvhHGQazORWLnEKzUgjRXdpzLO50YpqLvoskPU 1YgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=jFx3xxix0F8ETQCtd//YrBkRHyNpSKt8DUbehu81nM0=; b=kD7MaVRXN9n2i/OypgDP4Fmg0zWlPtBbDbm4xk6d5F/0u7tey1nc/1iru5L0kBqTMx pVrWpsPBb3BLC8rj3bYFPAiaDsjO8xLe1RAsaDXbOasi347A+ECN+p8+8IpK+/NI3cAr UNWSpyDTCRGbimiOibjm1RTxUGHkkkHNo6SQaMAVbWogjwwb3mkYgslB65MSotnvLPsn kYnkv3qq464uEN1Z1mlFndLp/6EKm5hYpLYtYDGbYdeiEjBn2vA3J6qndcYDDoHgXRqG 9Srp1GU8Ig4b/ItdAF7CQncEtmSb+Z8yEIC1bdrGtJ6fQtUErYIYfReSPo5BB1rWd3Bt AjEw== X-Gm-Message-State: AOAM533VKLkC2bSbeMWfgFSc9cbR8HvdSXBqryh0elIdqkaBtxbVXghw dDmACm/OZbSaht8nAp/3Unbnaj2Y9UL7eA== X-Received: by 2002:a17:906:7017:: with SMTP id n23mr56573249ejj.262.1594649326677; Mon, 13 Jul 2020 07:08:46 -0700 (PDT) Received: from net.saheed (54007186.dsl.pool.telekom.hu. [84.0.113.134]) by smtp.gmail.com with ESMTPSA id p4sm9800064eja.9.2020.07.13.07.08.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2020 07:08:45 -0700 (PDT) Subject: Re: [RFC PATCH 12/35] r8169: Tidy Success/Failure checks To: Heiner Kallweit , helgaas@kernel.org, Realtek linux nic maintainers , "David S. Miller" , Jakub Kicinski , Russell King Cc: bjorn@helgaas.com, skhan@linuxfoundation.org, linux-pci@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20200713122247.10985-1-refactormyself@gmail.com> <20200713122247.10985-13-refactormyself@gmail.com> From: Saheed Bolarinwa Message-ID: Date: Mon, 13 Jul 2020 15:09:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thank you for the review. On 7/13/20 3:45 PM, Heiner Kallweit wrote: > > Patches 11 and 12 are both trivial, wouldn't it make sense to merge them? > Apart from that: Acked-by: Heiner Kallweit I separated them for easy review, I will merge them in the next version. - Saheed