Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1011850ybh; Mon, 13 Jul 2020 07:13:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyD5GBSM9nwhFwaTG3YwcKdzgZqXHButcZek9jizS4IsNP11XS2zvEwng3qHSuGgxPVP1e X-Received: by 2002:a17:906:774d:: with SMTP id o13mr68163234ejn.373.1594649614105; Mon, 13 Jul 2020 07:13:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594649614; cv=none; d=google.com; s=arc-20160816; b=S6h0tR+ex3ktT5/nmlbDkzi5uLTJgEShLmb7tTw5QqkGwmPuRhpZlgPyxlK1X5yFgG Uz684FDaXUFClmtROR/ZyHnVDr6FnKHddjhq3lR9jUAYZh9fCJcdcWj2GajHoKLTP1t+ 8rPGgEeA7MTu9kfS/zC4r1ts1wYlnxcuk/nSr4tOIQCZG/wb/r26AG1YQOEAsmXiHERW pT5OSccy0TmzeYnMcPyNajmd8XodA56KNc5Dam7Ggm3PxpwvE9F9na4v2FmWMGTcXAfa 0/a9Vaty8xsAh0tshEo/0pTYlK4BCDy/3kSLiE8evS2HpIJf3mq55Qi4zVNfktd+sb4J yfEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=WyYsli8fqJKfYyX1azr1UjWckt1Wk+/8MvW65fU7r7g=; b=IaL7vhgl5//ulj0yZiLgO4GyC+Vv7I4qMTzokDFYmzQvYTNT+3hRpcOdBKq0Py/Bta mmmR8dvzNrAZJfmlGCASEG1h5kDdN4fJESb+pG1+XXh4ke2nX6jrUZsuCa5C/TYbppDz 540m7Ng2+Xh8lw3gyfIGbdMUEwyRbgECNoXfxBL9hpkiKNk20wSwlgLPD4QDxpfARJFc uKlG+zuKNPySQXMMBZbF9aoFvENGkErhz4WNG2MuqN9oWtGFClF9rHKHcFZuda2cnJ61 SqRq3bBRW/4DuATWE2E2Zkgx3b86uCc+AxNQ49AvIRjVeXyGgOzF3QEFnRaUcnGqUa4M f/qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=f+s0XeUd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t19si8507293ejx.443.2020.07.13.07.13.10; Mon, 13 Jul 2020 07:13:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=f+s0XeUd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730080AbgGMOMv (ORCPT + 99 others); Mon, 13 Jul 2020 10:12:51 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:33314 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729649AbgGMOMv (ORCPT ); Mon, 13 Jul 2020 10:12:51 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06DECJdl098089; Mon, 13 Jul 2020 14:12:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=WyYsli8fqJKfYyX1azr1UjWckt1Wk+/8MvW65fU7r7g=; b=f+s0XeUdUgOROnrFZx0wvSX/DtX0Kds3Xhe8Y8RLQudTyx1+a3JCnbacI/6Qjw98vf1q e1+2IYleEmEhvrZMi5jbvTeOsDj7ZKNVRzE0eQM/nyQj0r6iB6wIlnqNVgvxVjfR3WkP qe5fyweGu3rVirj4+unHdrKs2wr1X6Jl/XeRdb7kjM7q0Zza4pKgG8x39zvqVM4Ltmi2 Ng34zT/vX/fVQMWLqMVoBUpR1sfGdyw74vigwXSX3Vj1qXu+QoaB111FK6i/AkVOeRXU naSiTl8TKs5DCvIzGBil6f8+6LOUqF/ub32MlFjVvipkZwkFSv9Q+CI0Sp6z6B4pvbGj MQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 3274uqyacb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 13 Jul 2020 14:12:43 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06DE3YqJ146361; Mon, 13 Jul 2020 14:12:43 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 327q6qbgmc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Jul 2020 14:12:43 +0000 Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 06DECglu012869; Mon, 13 Jul 2020 14:12:42 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 13 Jul 2020 07:12:41 -0700 Date: Mon, 13 Jul 2020 17:12:35 +0300 From: Dan Carpenter To: Suraj Upadhyay Cc: manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] staging: qlge: qlge_main: Simplify while statements. Message-ID: <20200713141235.GT2549@kadam> References: <1bb472c5595d832221fd142dddb68907feeeecbe.1594642213.git.usuraj35@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1bb472c5595d832221fd142dddb68907feeeecbe.1594642213.git.usuraj35@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9680 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 mlxlogscore=949 bulkscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007130106 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9680 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 phishscore=0 spamscore=0 mlxlogscore=970 malwarescore=0 mlxscore=0 priorityscore=1501 adultscore=0 bulkscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007130107 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 13, 2020 at 05:50:14PM +0530, Suraj Upadhyay wrote: > Simplify while loops into more readable and simple for loops. > I don't think either is more clear that the other. Walter Harms hates count down loops and he's not entirely wrong... regards, dan carpenter