Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] fsi: fsi-occ: fix return value check in occ_probe()
To:     Xu Wang <vulab@iscas.ac.cn>, jk@ozlabs.org, joel@jms.id.au,
        alistair@popple.id.au, linux-fsi@lists.ozlabs.org
Cc:     linux-kernel@vger.kernel.org
References: <20200713033313.21487-1-vulab@iscas.ac.cn>
From:   Eddie James <eajames@linux.ibm.com>
Message-ID: <f2a70c79-15c4-339a-92c5-173d9303dc30@linux.ibm.com>
Date:   Mon, 13 Jul 2020 09:21:41 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <20200713033313.21487-1-vulab@iscas.ac.cn>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 7/12/20 10:33 PM, Xu Wang wrote:
> In case of error, the function platform_device_register_full()
> returns ERR_PTR() and never returns NULL. The NULL test in the
> return value check should be replaced with IS_ERR().


Thanks,

Reviewed-by: Eddie James <eajames@linux.ibm.com>


>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
>   drivers/fsi/fsi-occ.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-occ.c b/drivers/fsi/fsi-occ.c
> index 7da9c81759ac..9eeb856c8905 100644
> --- a/drivers/fsi/fsi-occ.c
> +++ b/drivers/fsi/fsi-occ.c
> @@ -555,7 +555,7 @@ static int occ_probe(struct platform_device *pdev)
>   
>   	hwmon_dev_info.id = occ->idx;
>   	hwmon_dev = platform_device_register_full(&hwmon_dev_info);
> -	if (!hwmon_dev)
> +	if (IS_ERR(hwmon_dev))
>   		dev_warn(dev, "failed to create hwmon device\n");
>   
>   	return 0;