Date: Wed, 3 May 2006 15:28:02 +0100
From: Al Viro <viro@ftp.linux.org.uk>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: linux-kernel@vger.kernel.org, Stephen Smalley <sds@tycho.nsa.gov>,
       Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH 11/14] Reworked patch for labels on user space messages
Message-ID: <20060503142802.GD27946@ftp.linux.org.uk>
References: <E1FaVfH-000531-LX@ZenIV.linux.org.uk> <9e4733910605030711p2acab747g8f2ea7fdbb95f3c4@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9e4733910605030711p2acab747g8f2ea7fdbb95f3c4@mail.gmail.com>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 988
Lines: 21

On Wed, May 03, 2006 at 10:11:52AM -0400, Jon Smirl wrote:
> Something seems to be wrong in selinux_get_task_sid. I am getting
> thousands of these and can't boot the kernel.

It's actually in security/selinux/hooks.c::selinux_disable() and gets
triggered if you have selinux enabled and explicitly disable afterwards.
Stephen Smalley had done a fix yesterday, basically adding
	selinux_enabled = 0;
after
        selinux_disabled = 1;
in there.  selinux_get_task_sid() happens to step on that in visible way
and nobody had caught that while this stuff was sitting in -mm ;-/

The only question I have about that patch: what would happen if we do not
have CONFIG_SECURITY_SELINUX_BOOTPARAM?  In that case selinux_enabled is
defined to 1, so...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/