Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030213AbWECOxW (ORCPT ); Wed, 3 May 2006 10:53:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965211AbWECOxW (ORCPT ); Wed, 3 May 2006 10:53:22 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:22921 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S965208AbWECOxV (ORCPT ); Wed, 3 May 2006 10:53:21 -0400 Date: Wed, 3 May 2006 15:53:20 +0100 From: Al Viro To: Jon Smirl Cc: linux-kernel@vger.kernel.org, Stephen Smalley , Linus Torvalds Subject: Re: [PATCH 11/14] Reworked patch for labels on user space messages Message-ID: <20060503145320.GE27946@ftp.linux.org.uk> References: <9e4733910605030711p2acab747g8f2ea7fdbb95f3c4@mail.gmail.com> <20060503142802.GD27946@ftp.linux.org.uk> <9e4733910605030740s6f394676g66377f2a48cd4209@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9e4733910605030740s6f394676g66377f2a48cd4209@mail.gmail.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1625 Lines: 38 On Wed, May 03, 2006 at 10:40:19AM -0400, Jon Smirl wrote: > On 5/3/06, Al Viro wrote: > >On Wed, May 03, 2006 at 10:11:52AM -0400, Jon Smirl wrote: > >> Something seems to be wrong in selinux_get_task_sid. I am getting > >> thousands of these and can't boot the kernel. > > > >It's actually in security/selinux/hooks.c::selinux_disable() and gets > >triggered if you have selinux enabled and explicitly disable afterwards. > >Stephen Smalley had done a fix yesterday, basically adding > > selinux_enabled = 0; > >after > > selinux_disabled = 1; > >in there. selinux_get_task_sid() happens to step on that in visible way > >and nobody had caught that while this stuff was sitting in -mm ;-/ > > > >The only question I have about that patch: what would happen if we do not > >have CONFIG_SECURITY_SELINUX_BOOTPARAM? In that case selinux_enabled is > >defined to 1, so... > > I have these config options set: > > CONFIG_SECURITY_SELINUX=y > CONFIG_SECURITY_SELINUX_BOOTPARAM=y > CONFIG_SECURITY_SELINUX_BOOTPARAM_VALUE=1 > CONFIG_SECURITY_SELINUX_DISABLE=y > CONFIG_SECURITY_SELINUX_DEVELOP=y > CONFIG_SECURITY_SELINUX_AVC_STATS=y > CONFIG_SECURITY_SELINUX_CHECKREQPROT_VALUE=1 > > SELinux needs to be built in or FC5 won't run. Then add the assignment above (selinux_enabled = 0;) in selinux_disable() and see if that fixes your problem. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/