Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 11/18] perf metric: Add referenced metrics to hash data
To:     Jiri Olsa <jolsa@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
CC:     lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Michael Petlan <mpetlan@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kajol Jain <kjain@linux.ibm.com>,
        "Paul A. Clarke" <pc@us.ibm.com>,
        Stephane Eranian <eranian@google.com>,
        Ian Rogers <irogers@google.com>
References: <20200712132634.138901-1-jolsa@kernel.org>
 <20200712132634.138901-12-jolsa@kernel.org>
From:   John Garry <john.garry@huawei.com>
Message-ID: <c55188aa-d8ff-ea5c-c8ed-a6f36d20c652@huawei.com>
Date:   Mon, 13 Jul 2020 17:27:53 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.2
MIME-Version: 1.0
In-Reply-To: <20200712132634.138901-12-jolsa@kernel.org>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 12/07/2020 14:26, Jiri Olsa wrote:
>   
> +int expr__add_ref(struct expr_parse_ctx *ctx, struct metric_ref *ref)
> +{
> +	struct expr_id_data *data_ptr = NULL, *old_data = NULL;
> +	char *old_key = NULL;
> +	char *name;
> +	int ret;
> +
> +	data_ptr = zalloc(sizeof(*data_ptr));
> +	if (!data_ptr)
> +		return -ENOMEM;
> +
> +	name = strdup(ref->metric_name);
> +	if (!name) {
> +		free(data_ptr);
> +		return -ENOMEM;
> +	}

JFYI, this was not compiling for me:

util/expr.c: In function ?expr__add_ref?:
util/expr.c:84:13: error: implicit declaration of function ?zalloc?; did 
you mean ?valloc?? [-Werror=implicit-function-declaration]
  data_ptr = zalloc(sizeof(*data_ptr));
  ^~~~~~
  valloc
util/expr.c:84:13: error: nested extern declaration of ?zalloc? 
[-Werror=nested-externs]
util/expr.c:84:11: error: assignment to ?struct expr_id_data *? from 
?int? makes pointer from integer without a cast [-Werror=int-conversion]
  data_ptr = zalloc(sizeof(*data_ptr));
^
  LDutil/arm-spe-decoder/perf-in.o
cc1: all warnings being treated as errors

I think the zalloc.h include is missing.

Thanks,
john